magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Feature gap: Add `guestFlush` to Snapshot

Open Cezarus27 opened this issue 1 month ago • 8 comments

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `guest_flush` field to `google_compute_snapshot` resource (beta)

Cezarus27 avatar Nov 25 '25 11:11 Cezarus27

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Nov 25 '25 11:11 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 40 insertions(+)) google-beta provider: Diff ( 4 files changed, 115 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Nov 25 '25 17:11 modular-magician

Tests analytics

Total tests: 1308 Passed tests: 1221 Skipped tests: 83 Affected tests: 4

Click here to see the affected service packages
  • compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy
  • TestAccComputeSnapshot_snapshotBasic2Example

Get to know how VCR tests work

modular-magician avatar Nov 25 '25 18:11 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log] TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log] TestAccComputeSnapshot_snapshotBasic2Example [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode: TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Nov 25 '25 18:11 modular-magician

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 28 '25 09:11 github-actions[bot]

@ScottSuarez could you rerun failed jobs?

Cezarus27 avatar Dec 04 '25 11:12 Cezarus27

@ScottSuarez This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 08 '25 09:12 github-actions[bot]

@GoogleCloudPlatform/terraform-team @ScottSuarez This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 10 '25 09:12 github-actions[bot]

/gcbrun

ScottSuarez avatar Dec 15 '25 18:12 ScottSuarez

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 40 insertions(+)) google-beta provider: Diff ( 4 files changed, 115 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

modular-magician avatar Dec 15 '25 18:12 modular-magician

Tests analytics

Total tests: 1317 Passed tests: 1231 Skipped tests: 83 Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update
  • TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy

Get to know how VCR tests work

modular-magician avatar Dec 15 '25 19:12 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log] TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode: TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Dec 15 '25 19:12 modular-magician