Add periodic export configuration to Instance.yaml

[efeelaiho]

Added configuration for periodic export including KMS key, GCS URI, and start time parameters.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

looker: added `periodic_export_config`  field to `google_looker_instance` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 339 insertions(+)) google-beta provider: Diff ( 3 files changed, 339 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  periodic_export_config {
    gcs_uri = # value needed
    kms_key = # value needed
    start_time {
      hours   = # value needed
      minutes = # value needed
      nanos   = # value needed
      seconds = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 8 Passed tests: 8 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• looker

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 339 insertions(+)) google-beta provider: Diff ( 3 files changed, 339 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_looker_instance" "primary" {
  periodic_export_config {
    gcs_uri = # value needed
    kms_key = # value needed
    start_time {
      hours   = # value needed
      minutes = # value needed
      nanos   = # value needed
      seconds = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 9 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_updatePeriodicExport

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 425 insertions(+)) google-beta provider: Diff ( 4 files changed, 425 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 9 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_updatePeriodicExport

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccLookerInstance_updatePeriodicExport [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccLookerInstance_updatePeriodicExport [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 425 insertions(+)) google-beta provider: Diff ( 4 files changed, 425 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 9 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_updatePeriodicExport

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccLookerInstance_updatePeriodicExport [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 422 insertions(+)) google-beta provider: Diff ( 4 files changed, 422 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 109 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 9 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• looker

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccLookerInstance_updatePeriodicExport

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccLookerInstance_updatePeriodicExport [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[efeelaiho]

@ScottSuarez the error I am getting is around the permissions of the bucket that these update calls will essentially write to:

Error: Error updating Instance "projects/ci-test-project-188019/locations/us-central1/instances/tf-test-looker-alr1vpqj7n": googleapi: Error 400: The provided gcs bucket does not exist or the service account is missing one or both of the required permissions: storage.objects.delete, storage.objects.create.

[ScottSuarez]

Hey ! let me take a look

[ScottSuarez]

https://github.com/ScottSuarez/magic-modules/blob/38520c4e947e0dc51a365d0845cc73cdf394f4d9/mmv1/third_party/terraform/services/eventarc/resource_eventarc_message_bus_test.go#L315-L321

Here is how you do it for handwritten files.

[github-actions[bot]]

@efeelaiho, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.