magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat(apihub): Add support for API Hub Attributes Allowed Values

Open jayce-jia opened this issue 2 months ago • 14 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/24372 Given system defined attributes are immutable, we need a way to manage the allowed values seperately

  • Add a virtual resource google_apihub_attribute_allowed_values to manage allowed values only
  • Customized create/update/delete behaviours to support CRUD for virtual resource google_apihub_attribute_allowed_values
  • Immutable values will be preserved during the modification

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_apihub_attribute_allowed_values`

jayce-jia avatar Oct 02 '25 11:10 jayce-jia

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Oct 02 '25 11:10 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 862 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 862 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 202 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apihub_attribute_allowed_values (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apihub_attribute_allowed_values" "primary" {
  allowed_values {
    description  = # value needed
    display_name = # value needed
    id           = # value needed
    immutable    = # value needed
  }
  attribute_id = # value needed
  location     = # value needed
}


modular-magician avatar Oct 02 '25 19:10 modular-magician

Tests analytics

Total tests: 2 Passed tests: 1 Skipped tests: 1 Affected tests: 0

Click here to see the affected service packages
  • apihub

🟢 All tests passed!

View the build log

modular-magician avatar Oct 02 '25 19:10 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 08 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 10 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 17 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 24 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 31 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 07 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 14 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 21 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 8 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 28 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 9 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 05 '25 09:12 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 10 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 12 '25 09:12 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 11 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 19 '25 09:12 github-actions[bot]