magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Fixes https://github.com/hashicorp/terraform-provider-google/issues/1

Open copybara-service[bot] opened this issue 3 months ago • 17 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/1

The network_tier field in the Compute Address resource now supports 'FOOBAR' as an additional enum value.

compute: added `FOOBAR` as a `network_tier` in `google_compute_address`

copybara-service[bot] avatar Sep 26 '25 22:09 copybara-service[bot]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Sep 26 '25 22:09 github-actions[bot]

This is a dummy change I made as part of a test! It's not intended to be merged, I'll close it when I'm done.

@modular-magician reassign-reviewer rileykarson

rileykarson avatar Sep 26 '25 22:09 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

modular-magician avatar Sep 26 '25 23:09 modular-magician

Tests analytics

Total tests: 1293 Passed tests: 1206 Skipped tests: 84 Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample
  • TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update
  • TestAccDataSourceGoogleStoragePoolTypes

Get to know how VCR tests work

modular-magician avatar Sep 26 '25 23:09 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeNetworkFirewallPolicyPacketMirroringRule_computeNetworkFirewallPolicyPacketMirroringRuleExample [Debug log] TestAccComputeNetworkFirewallPolicyPacketMirroringRule_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode: TestAccDataSourceGoogleStoragePoolTypes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Sep 27 '25 00:09 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 01 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 03 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 10 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 17 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 24 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 31 '25 09:10 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 07 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 14 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 8 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 21 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 9 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Nov 28 '25 09:11 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 10 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 05 '25 09:12 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 11 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 12 '25 09:12 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 12 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Dec 19 '25 09:12 github-actions[bot]