GoogleCloudPlatform
Add missing fields to google_dialogflow_cx_playbook resource
fulfill request https://github.com/hashicorp/terraform-provider-google/issues/23328
Previous PR: https://github.com/GoogleCloudPlatform/magic-modules/pull/14446
dialogflowcx: added `handlers`, `inputParameterDefinitions`, and `outputParameterDefinitions` to `google_dialogflow_cx_playbook` resource.
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3550 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 967 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 41 Skipped tests: 0 Affected tests: 2
Click here to see the affected service packages
- dialogflowcx
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDialogflowCXPlaybook_dialogflowcxPlaybookBasicExample
- TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXPlaybook_dialogflowcxPlaybookBasicExample [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3550 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 967 insertions(+))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 12563 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3550 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 967 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 42 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- dialogflowcx
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample
Get to know how VCR tests work
🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
Tests analytics
Total tests: 43 Passed tests: 42 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- dialogflowcx
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 635 insertions(+))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 635 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11224 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 635 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 721 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 42 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- dialogflowcx
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXPlaybook_dialogflowcxPlaybookFulfillmentExample [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 721 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 721 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
google-beta provider: Diff ( 4 files changed, 11396 insertions(+), 113 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3327 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 721 insertions(+))
Tests analytics
Total tests: 43 Passed tests: 43 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- dialogflowcx
🟢 All tests passed!
View the build log