Add application awareness on interconnect

[abhijeetkjha-google]

compute: added `applicationAwareInterconnect` and `aaiEnabled` field in `google_compute_interconnect` resource

This feature allows customers to explicitly control how the bandwidth at the Cloud Interconnect -> Customer on-prem router is managed for the traffic egressing Google Cloud on their Dedicated Interconnect or Cross-Cloud Interconnect deployments.

With application awareness on Interconnect, customers have the ability to define how their Interconnect capacity is shared across their different workloads and ensure higher reliability for their mission-critical traffic.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+)) google-beta provider: Diff ( 4 files changed, 603 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  application_aware_interconnect {
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1226 Passed tests: 1142 Skipped tests: 83 Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[abhijeetkjha-google]

googleapi: Error 400: Invalid value for field 'resource.aaiEnabled': 'true'. Please contact your account team to request enabling application awareness on Interconnect

How do we enable this @abhijeetkjha-google

Hi @c2thorn, the projects used here for VCR-tests are not whitelisted for the use of application awareness on interconnect feature, I have raised the request for this whitelisting, Will update you once, the tests are passing. Thanks.

[abhijeetkjha-google]

@abhijeetkjha-google just to make sure can you also do the nightly tests? So all 3 should be

ci-test-project-188019
ci-test-project-nightly-ga
ci-test-project-nightly-beta

Yes, i have raised request for these as well. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+)) google-beta provider: Diff ( 4 files changed, 603 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (6 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  application_aware_interconnect {
    shape_average_percentage {
      percentage    = # value needed
      traffic_class = # value needed
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+)) google-beta provider: Diff ( 4 files changed, 621 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1237 Passed tests: 1153 Skipped tests: 83 Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1237 Passed tests: 1153 Skipped tests: 83 Affected tests: 1

Click here to see the affected service packages

• compute

#### Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectBasicTestExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccComputeInterconnect_computeInterconnectBasicTestExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[abhijeetkjha-google]

Hi @c2thorn , I have had the terraform projects whitelisted and the vcr tests are passing now. Please review. Thanks.

[c2thorn]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 66 insertions(+)) google-beta provider: Diff ( 4 files changed, 621 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 168 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1240 Passed tests: 1157 Skipped tests: 83 Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[abhijeetkjha-google]

Hi @c2thorn , Lemme know if there's anything left to be done from my side. Thanks/