GoogleCloudPlatform
feat: (storage) add flag to force empty content type
Release Note Template for Downstream PRs (will be copied) Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17058 See Write release notes for guidance.
storage: added `force_empty_content_type` flag to force empty content type in resource `google_storage_bucket_object`
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 50 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 50 insertions(+), 2 deletions(-))
Missing doc report (experimental)
The following resources have fields missing in documents.
google_storage_bucket_object- Expected Document Path:
/website/docs/r/storage_bucket_object.html.markdown - Fields:
[force_empty_content_type]
- Expected Document Path:
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageObject_content
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageObject_content [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageObject_content
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageObject_content [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 52 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 53 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 53 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 53 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 53 insertions(+), 2 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 59 insertions(+), 6 deletions(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
force_empty_content_typeadded as optional with a default value and force new on pre-existing resourcegoogle_storage_bucket_object. This can be allowed if there is a confirmed API-level default that matches the schema default - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 58 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 58 insertions(+), 6 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageObject_content
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageObject_content [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageObject_content
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageObject_content [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.