GoogleCloudPlatform
Adds new IP Filter access fields
This PR adds two new boolean fields to the google_storage_bucket.ip_filter block,
- allow_cross_org_vpcs
- allow_all_service_agent_access
storage: added `allow_cross_org_vpcs` and `allow_all_service_agent_access` fields to `google_storage_bucket` resource.
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 89 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 89 insertions(+), 5 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 86 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 86 insertions(+), 5 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageBucket_IPFilter
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_IPFilter [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageBucket_IPFilter
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_IPFilter [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Hi @rileykarson, It appears that the recent API change in ip_filter block marked allow_all_service_agent_access required. This change caused this failure: https://github.com/hashicorp/terraform-provider-google/issues/23370. Discussing offline for further clarifications.
Reference: https://cloud.google.com/storage/docs/ip-filtering-overview, The feature is in Preview stage.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 87 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 87 insertions(+), 6 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 89 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 89 insertions(+), 6 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 89 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 89 insertions(+), 6 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Tests analytics
Total tests: 123 Passed tests: 113 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 86 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 3 files changed, 86 insertions(+), 6 deletions(-))
Tests analytics
Total tests: 123 Passed tests: 112 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageBucket_IPFilter
Get to know how VCR tests work