GoogleCloudPlatform
fix: (storage) data type change for retention_period
Release Note Template for Downstream PRs (will be copied) Fixes: https://github.com/hashicorp/terraform-provider-google/issues/19051 See Write release notes for guidance.
storage: changed `retention_period` to `string` data type in resource `google_storage_bucket`
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 16 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 7 insertions(+), 1 deletion(-))
Errors
google provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- storage
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 120 Passed tests: 109 Skipped tests: 10 Affected tests: 1
Click here to see the affected service packages
- storage
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageBucket_storageClass
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_storageClass [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🟢 All tests passed!
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 16 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 19 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 19 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Errors
google provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- storage
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 21 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 21 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 4 files changed, 22 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
We might need state upgrader for this breaking change. Can you please check if that will be helpful? References: https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/state-migration https://github.com/GoogleCloudPlatform/magic-modules/pull/11471/files
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 558 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 5 files changed, 558 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
We might need state upgrader for this breaking change. Can you please check if that will be helpful? References: https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/state-migration https://github.com/GoogleCloudPlatform/magic-modules/pull/11471/files
added state upgrader
Tests analytics
Total tests: 120 Passed tests: 110 Skipped tests: 10 Affected tests: 0
Click here to see the affected service packages
- storage
🟢 All tests passed!
View the build log
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@BBBmau can you please review the state migration code as it was historically added/written by only magic-modules maintainers?
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 561 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 5 files changed, 561 insertions(+), 15 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
retention_policy.retention_periodchanged from TypeInt to TypeString ongoogle_storage_bucket- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Errors
google-beta provider:
- Failed to detect subcategory in the frontmatter in file website/docs/guides/version_7_upgrade.html.markdown.
Tests analytics
Total tests: 123 Passed tests: 111 Skipped tests: 10 Affected tests: 2
Click here to see the affected service packages
- storage
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccStorageBucket_IPFilter
- TestAccStorageBucket_storageClass
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_storageClass [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_IPFilter [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_storageClass[Debug log]🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_IPFilter[Error message] [Debug log]🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
unrelated test case is failing
@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.