magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Remove static check for connection creation

Open anjalisoni3655 opened this issue 6 months ago • 2 comments

This will help in resolving one of the internal bug where static check of exactly_one_of is not needed with authType UNSPECIFIED.

anjalisoni3655 avatar Jun 12 '25 16:06 anjalisoni3655

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Jun 12 '25 16:06 github-actions[bot]

can you resolve the conflicts on this PR? Also can you explain a bit more what this UNSPECIFIED type is coming from? To me this exactly_one_of is to prevent conflicts from occuring in auth_config, It's not clear where this unspecified type comes from that you're referring to.

Hello, apologies for the typo. So, the auth type can also be "AUTH_TYPE_UNSPECIFIED" For this case, the user won't be providing an auth object like user_password, oauth2ClientCredentials etc. But due to the above exactly_one_of check, the auth type "AUTH_TYPE_UNSPECIFIED" doesn't work. e.g; auth_config{ auth_type = "AUTH_TYPE_UNSPECIFIED"} , the below error is thrown. So, to fix the issue, I am currently removing this check image

anjalisoni3655 avatar Jun 20 '25 10:06 anjalisoni3655

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 25 '25 09:06 github-actions[bot]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 27 '25 09:06 github-actions[bot]

@modular-magician reassign-reviewer

rileykarson avatar Jul 01 '25 17:07 rileykarson

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 04 '25 09:07 github-actions[bot]

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 08 '25 09:07 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jul 10 '25 16:07 modular-magician

@anjalisoni3655, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jul 24 '25 09:07 github-actions[bot]

@anjalisoni3655, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Aug 07 '25 09:08 github-actions[bot]

@anjalisoni3655, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Aug 19 '25 09:08 github-actions[bot]

@anjalisoni3655, this PR is being closed due to inactivity.

github-actions[bot] avatar Aug 21 '25 09:08 github-actions[bot]