Promote network_security.backend_authentication_config to GA
network_security: promote `backend_authentication_config` to GA
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 9 files changed, 1180 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 6 files changed, 5 insertions(+), 35 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1310 Passed tests: 1220 Skipped tests: 89 Affected tests: 1
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeBackendService_backendServiceTlsSettingsExample
🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 9 files changed, 1181 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 6 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 9 files changed, 1181 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 6 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1316 Passed tests: 1226 Skipped tests: 89 Affected tests: 1
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeBackendService_backendServiceTlsSettingsExample
🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1316 Passed tests: 1226 Skipped tests: 89 Affected tests: 1
Click here to see the affected service packages
- networksecurity
- certificatemanager
- compute
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeBackendService_backendServiceTlsSettingsExample
🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 9 files changed, 1181 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 6 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1318 Passed tests: 1228 Skipped tests: 89 Affected tests: 1
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeBackendService_backendServiceTlsSettingsExample
🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 9 files changed, 1181 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 6 insertions(+), 36 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1318 Passed tests: 1228 Skipped tests: 89 Affected tests: 1
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeBackendService_backendServiceTlsSettingsExample
🔴 Tests failed during RECORDING mode:
TestAccComputeBackendService_backendServiceTlsSettingsExample [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 12 files changed, 1439 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 38 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccComputeBackendService_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1318 Passed tests: 1229 Skipped tests: 89 Affected tests: 0
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
View the build log
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
stub for ga tests https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_NETWORKSECURITY/398975
Hi there, I'm seeing failures on TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
------- Stdout: -------
=== RUN TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
=== PAUSE TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
=== CONT TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
resource_network_security_backend_authentication_config_generated_test.go:151: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_compute_backend_service.default will be updated in-place
~ resource "google_compute_backend_service" "default" {
id = "projects/xxxx/global/backendServices/tf-test-backend-servicerg13tvfl2l"
name = "tf-test-backend-servicerg13tvfl2l"
# (23 unchanged attributes hidden)
+ tls_settings {
+ authentication_config = "//networksecurity.googleapis.com/projects/xxxx/locations/global/backendAuthenticationConfigs/authenticationrg13tvfl2l"
+ sni = "example.com"
+ subject_alt_names {
+ dns_name = "example.com"
}
+ subject_alt_names {
+ uniform_resource_identifier = "https://example.com/
}
}
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample (72.58s)
FAIL
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 12 files changed, 1439 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 38 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccComputeBackendService_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1329 Passed tests: 1240 Skipped tests: 89 Affected tests: 0
Click here to see the affected service packages
- compute
- networksecurity
- certificatemanager
View the build log
@ScottSuarez tests should work now, since compute API have been updated. However I've got some flakes while running tests: make testacc TEST=./google/services/networksecurity TESTARGS='-run=TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample' Failed. TF_LOG=DEBUG make testacc TEST=./google/services/networksecurity TESTARGS='-run=TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample' Succeed.
Hi @ScottSuarez, Can you please try tests once again, everything should be rolled out now.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 12 files changed, 1439 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 6 files changed, 8 insertions(+), 38 deletions(-))
Open in Cloud Shell: Diff ( 9 files changed, 258 insertions(+), 7 deletions(-))
Non-exercised tests
🔴 Tests were added that are GA-only additions and require manual runs:
- TestAccComputeBackendService_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_backendServiceTlsSettingsExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigBasicExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample
- TestAccNetworkSecurityBackendAuthenticationConfig_networkSecurityBackendAuthenticationConfigFullExample_update
Tests analytics
Total tests: 1334 Passed tests: 1245 Skipped tests: 89 Affected tests: 0
Click here to see the affected service packages
- certificatemanager
- compute
- networksecurity
View the build log
stub for ga tests https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_NETWORKSECURITY/411578