magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard
verified publisher icon GoogleCloudPlatform

Promote autokey resources to GA

Open nb-goog opened this issue 6 months ago • 22 comments

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Promoting Autokey resources to GA from beta

nb-goog avatar Jun 05 '25 03:06 nb-goog

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Jun 05 '25 03:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 967 insertions(+), 16 deletions(-)) google-beta provider: Diff ( 7 files changed, 2 insertions(+), 16 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 05 '25 03:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 43 Passed tests: 37 Skipped tests: 4 Affected tests: 2

Click here to see the affected service packages
  • kms
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician avatar Jun 05 '25 03:06 modular-magician

🔴 Tests failed during RECORDING mode: TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Error message] [Debug log] TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 05 '25 03:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 1482 insertions(+), 16 deletions(-)) google-beta provider: Diff ( 8 files changed, 2 insertions(+), 17 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 09 '25 08:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 1493 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 13 files changed, 25 insertions(+), 34 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 09 '25 09:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician avatar Jun 09 '25 09:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

All service packages are affected

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician avatar Jun 09 '25 09:06 modular-magician

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 09 '25 09:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 1490 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 13 files changed, 7 insertions(+), 22 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 18 '25 06:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 1490 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 13 files changed, 7 insertions(+), 22 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 18 '25 06:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 1490 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 13 files changed, 7 insertions(+), 22 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 18 '25 06:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 5302 Passed tests: 4689 Skipped tests: 586 Affected tests: 27

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician avatar Jun 18 '25 08:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 5302 Passed tests: 4687 Skipped tests: 586 Affected tests: 29

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician avatar Jun 18 '25 08:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Tests analytics

Total tests: 5302 Passed tests: 4685 Skipped tests: 586 Affected tests: 31

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample
  • TestAccKMSKeyHandle_kmsKeyHandleBasicExample

Get to know how VCR tests work

modular-magician avatar Jun 18 '25 08:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__access_level_condition [Error message] [Debug log] TestAccAccessContextManager__access_level_custom [Error message] [Debug log] TestAccAccessContextManager__access_level_full [Error message] [Debug log] TestAccAccessContextManager__access_policy [Error message] [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log] TestAccAccessContextManager__service_perimeters [Error message] [Debug log] TestAccContainerNodePool_resize [Error message] [Debug log] TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log] TestAccContainerNodePool_withManagement [Error message] [Debug log] TestAccContainerNodePool_withMaxRunDuration [Error message] [Debug log] TestAccContainerNodePool_withNodeConfig [Error message] [Debug log] TestAccContainerNodePool_withTaintsUpdate [Error message] [Debug log] TestAccContainerNodePool_withUpgradeSettings [Error message] [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Error message] [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log] TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Error message] [Debug log] TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 18 '25 09:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__access_level_custom [Error message] [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccContainerNodePool_fastSocket [Error message] [Debug log] TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log] TestAccContainerNodePool_withCgroupMode [Error message] [Debug log] TestAccContainerNodePool_withConfidentialNodes [Error message] [Debug log] TestAccContainerNodePool_withHugepageConfig [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log] TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Error message] [Debug log] TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 18 '25 10:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccContainerNodePool_privateRegistry [Error message] [Debug log] TestAccContainerNodePool_version [Error message] [Debug log] TestAccContainerNodePool_withCgroupMode [Error message] [Debug log] TestAccContainerNodePool_withKubeletConfig [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log] TestAccKMSAutokeyConfig_kmsAutokeyConfigAllExample [Error message] [Debug log] TestAccKMSKeyHandle_kmsKeyHandleBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 18 '25 10:06 modular-magician

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 20 '25 09:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1148 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 11 files changed, 5 insertions(+), 20 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 20 '25 13:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic

Tests analytics

Total tests: 5309 Passed tests: 4690 Skipped tests: 587 Affected tests: 32

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 32 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician avatar Jun 20 '25 15:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log] TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log] TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 20 '25 17:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1117 insertions(+), 22 deletions(-)) google-beta provider: Diff ( 11 files changed, 7 insertions(+), 21 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 24 '25 02:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1161 insertions(+), 21 deletions(-)) google-beta provider: Diff ( 11 files changed, 5 insertions(+), 20 deletions(-))

Multiple resources added

This PR adds multiple new resources: google_kms_autokey_config, google_kms_key_handle. This makes review significantly more difficult. Please split it into multiple PRs, one per resource. An override-multiple-resources label can be added to allow merging.

modular-magician avatar Jun 24 '25 03:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic

Tests analytics

Total tests: 5313 Passed tests: 4696 Skipped tests: 588 Affected tests: 29

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_level_full
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician avatar Jun 24 '25 04:06 modular-magician

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDataSourceGoogleKmsAutokeyConfig_basic
  • TestAccDataSourceGoogleKmsKeyHandle_basic
  • TestAccDataSourceGoogleKmsKeyHandles_basic

Tests analytics

Total tests: 5313 Passed tests: 4695 Skipped tests: 588 Affected tests: 30

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__access_level_full
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician avatar Jun 24 '25 05:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__access_level_condition [Error message] [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log] TestAccAccessContextManager__service_perimeters [Error message] [Debug log] TestAccContainerNodePool_resourceManagerTags [Error message] [Debug log] TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 24 '25 06:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log] TestAccAccessContextManager__service_perimeters [Error message] [Debug log] TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 24 '25 07:06 modular-magician

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 24 '25 09:06 github-actions[bot]

@modular-magician reassign-reviewer

rileykarson avatar Jul 01 '25 17:07 rileykarson