magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update Gemini GeminiGcpEnablementSettingBinding resource -- change allowed products

Open mwiatrowski opened this issue 10 months ago • 10 comments

gemini: updated allowed product values for field `product` in `google_gemini_gemini_gcp_enablement_setting_binding` resource

mwiatrowski avatar May 28 '25 14:05 mwiatrowski

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar May 28 '25 14:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 7 insertions(+), 4 deletions(-)) google-beta provider: Diff ( 3 files changed, 7 insertions(+), 4 deletions(-))

modular-magician avatar May 28 '25 15:05 modular-magician

Tests analytics

Total tests: 20 Passed tests: 19 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • gemini
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update

Get to know how VCR tests work

modular-magician avatar May 28 '25 15:05 modular-magician

🔴 Tests failed during RECORDING mode: TestAccGeminiGeminiGcpEnablementSettingBinding_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar May 28 '25 15:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-)) google-beta provider: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar May 29 '25 16:05 modular-magician

Tests analytics

Total tests: 20 Passed tests: 19 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • gemini
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiGeminiGcpEnablementSettingBinding_update

Get to know how VCR tests work

modular-magician avatar May 29 '25 16:05 modular-magician

🟢 Tests passed during RECORDING mode: TestAccGeminiGeminiGcpEnablementSettingBinding_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

modular-magician avatar May 29 '25 16:05 modular-magician

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 02 '25 09:06 github-actions[bot]

@NickElliot That enum value still exists, but it's no longer accepted for that resource (creation/update will return an error). What should I do in that case? Is it better to list all possible values, or only the valid ones?

mwiatrowski avatar Jun 04 '25 08:06 mwiatrowski

@mwiatrowski, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 19 '25 09:06 github-actions[bot]