magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard
verified publisher icon GoogleCloudPlatform

Add resource_manager_tags support to Network api

Open Veronichka opened this issue 7 months ago • 17 comments

Added resource manager tags support to Network. Part of https://github.com/hashicorp/terraform-provider-google/issues/23225

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: add `params.resourceManagerTags` field to the `google_compute_network`

Veronichka avatar May 28 '25 14:05 Veronichka

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 65 insertions(+)) google-beta provider: Diff ( 5 files changed, 146 insertions(+), 18 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar May 28 '25 15:05 modular-magician

Tests analytics

Total tests: 1206 Passed tests: 1120 Skipped tests: 83 Affected tests: 3

Click here to see the affected service packages
  • compute
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample
  • TestAccComputeFirewallPolicyWithRules_update
  • TestAccComputeNetwork_resourceManagerTags

Get to know how VCR tests work

modular-magician avatar May 28 '25 15:05 modular-magician

🔴 Tests failed during RECORDING mode: TestAccComputeFirewallPolicyWithRules_computeFirewallPolicyWithRulesFullExample [Error message] [Debug log] TestAccComputeFirewallPolicyWithRules_update [Error message] [Debug log] TestAccComputeNetwork_resourceManagerTags [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar May 28 '25 15:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 166 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 166 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 11 '25 13:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 164 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 164 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 11 '25 13:06 modular-magician

Tests analytics

Total tests: 5286 Passed tests: 4672 Skipped tests: 583 Affected tests: 31

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccComputeNetwork_resourceManagerTags
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician avatar Jun 11 '25 15:06 modular-magician

Tests analytics

Total tests: 5286 Passed tests: 4674 Skipped tests: 583 Affected tests: 29

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 29 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeNetwork_resourceManagerTags
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician avatar Jun 11 '25 15:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccComputeNetwork_resourceManagerTags [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log] TestAccDataSourceGoogleGkeHubFeature_basic [Debug log] TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log] TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccContainerNodePool_resize [Error message] [Debug log] TestAccContainerNodePool_withConfidentialNodes [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 11 '25 17:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeNetwork_resourceManagerTags [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log] TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log] TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 11 '25 17:06 modular-magician

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Jun 16 '25 10:06 github-actions[bot]

@modular-magician reassign-reviewer

Assign a new reviewer, as I'll be OOO most of the week.

shuyama1 avatar Jun 16 '25 13:06 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 20 '25 10:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 20 '25 10:06 modular-magician

Tests analytics

Total tests: 5310 Passed tests: 4693 Skipped tests: 587 Affected tests: 30

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician avatar Jun 20 '25 12:06 modular-magician

Tests analytics

Total tests: 5310 Passed tests: 4693 Skipped tests: 587 Affected tests: 30

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample
  • TestAccLoggingFolderSettings_update

Get to know how VCR tests work

modular-magician avatar Jun 20 '25 12:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log] TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log] TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__access_level_condition [Error message] [Debug log] TestAccAccessContextManager__access_level_full [Error message] [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log] TestAccAccessContextManager__service_perimeters [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 20 '25 13:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log] TestAccLoggingFolderSettings_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccLoggingFolderSettings_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccDialogflowEncryptionSpec_dialogflowEncryptionSpecBasicExample [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 20 '25 14:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 23 '25 16:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) google-beta provider: Diff ( 6 files changed, 160 insertions(+), 31 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 36 insertions(+))

modular-magician avatar Jun 23 '25 16:06 modular-magician

Tests analytics

Total tests: 5310 Passed tests: 4695 Skipped tests: 587 Affected tests: 28

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_regionalAutoscaling
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNodeConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician avatar Jun 23 '25 18:06 modular-magician

Tests analytics

Total tests: 5310 Passed tests: 4696 Skipped tests: 587 Affected tests: 27

Click here to see the affected service packages

All service packages are affected

#### Action taken
Found 27 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__gcp_user_access_binding
  • TestAccContainerNodePool_EmptyGuestAccelerator
  • TestAccContainerNodePool_autoscaling
  • TestAccContainerNodePool_fastSocket
  • TestAccContainerNodePool_gcfsConfig
  • TestAccContainerNodePool_gvnic
  • TestAccContainerNodePool_privateRegistry
  • TestAccContainerNodePool_resize
  • TestAccContainerNodePool_resourceManagerTags
  • TestAccContainerNodePool_totalSize
  • TestAccContainerNodePool_version
  • TestAccContainerNodePool_withCgroupMode
  • TestAccContainerNodePool_withConfidentialNodes
  • TestAccContainerNodePool_withEnablePrivateNodesToggle
  • TestAccContainerNodePool_withHugepageConfig
  • TestAccContainerNodePool_withKubeletConfig
  • TestAccContainerNodePool_withLinuxNodeConfig
  • TestAccContainerNodePool_withLoggingVariantUpdates
  • TestAccContainerNodePool_withMachineAndDiskUpdate
  • TestAccContainerNodePool_withManagement
  • TestAccContainerNodePool_withMaxRunDuration
  • TestAccContainerNodePool_withNetworkConfig
  • TestAccContainerNodePool_withTaintsUpdate
  • TestAccContainerNodePool_withUpgradeSettings
  • TestAccContainerNodePool_withWindowsNodeConfig
  • TestAccContainerNodePool_withWorkloadIdentityConfig
  • TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample

Get to know how VCR tests work

modular-magician avatar Jun 23 '25 18:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_update [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_regionalAutoscaling [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNodeConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__access_levels [Error message] [Debug log] TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 23 '25 19:06 modular-magician

🟢 Tests passed during RECORDING mode: TestAccAccessContextManager__access_level [Debug log] TestAccAccessContextManager__access_level_condition [Debug log] TestAccAccessContextManager__access_level_custom [Debug log] TestAccAccessContextManager__access_level_full [Debug log] TestAccAccessContextManager__access_levels [Debug log] TestAccAccessContextManager__access_policy [Debug log] TestAccAccessContextManager__access_policy_scoped [Debug log] TestAccAccessContextManager__authorized_orgs_desc [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log] TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log] TestAccAccessContextManager__service_perimeters [Debug log] TestAccContainerNodePool_EmptyGuestAccelerator [Debug log] TestAccContainerNodePool_autoscaling [Debug log] TestAccContainerNodePool_fastSocket [Debug log] TestAccContainerNodePool_gcfsConfig [Debug log] TestAccContainerNodePool_gvnic [Debug log] TestAccContainerNodePool_privateRegistry [Debug log] TestAccContainerNodePool_resize [Debug log] TestAccContainerNodePool_resourceManagerTags [Debug log] TestAccContainerNodePool_totalSize [Debug log] TestAccContainerNodePool_version [Debug log] TestAccContainerNodePool_withCgroupMode [Debug log] TestAccContainerNodePool_withConfidentialNodes [Debug log] TestAccContainerNodePool_withEnablePrivateNodesToggle [Debug log] TestAccContainerNodePool_withHugepageConfig [Debug log] TestAccContainerNodePool_withKubeletConfig [Debug log] TestAccContainerNodePool_withLinuxNodeConfig [Debug log] TestAccContainerNodePool_withLoggingVariantUpdates [Debug log] TestAccContainerNodePool_withMachineAndDiskUpdate [Debug log] TestAccContainerNodePool_withManagement [Debug log] TestAccContainerNodePool_withMaxRunDuration [Debug log] TestAccContainerNodePool_withNetworkConfig [Debug log] TestAccContainerNodePool_withTaintsUpdate [Debug log] TestAccContainerNodePool_withUpgradeSettings [Debug log] TestAccContainerNodePool_withWindowsNodeConfig [Debug log] TestAccContainerNodePool_withWorkloadIdentityConfig [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccContainerNodePool_withNetworkConfig [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log] TestAccAccessContextManager__service_perimeter [Error message] [Debug log] TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log] TestAccHealthcarePipelineJob_healthcarePipelineJobBackfillExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Jun 23 '25 20:06 modular-magician

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 25 '25 09:06 github-actions[bot]

failing tests look unrelated.

melinath avatar Jun 26 '25 23:06 melinath