magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat: (storage) add custom_headers for folder resource

Open gurusai-voleti opened this issue 7 months ago • 36 comments

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: added `custom_headers` for resource `google_storage_folder`

gurusai-voleti avatar May 26 '25 11:05 gurusai-voleti

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 36 insertions(+), 1 deletion(-)) google-beta provider: Diff ( 4 files changed, 36 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_folder (5 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_folder" "primary" {
  custom_headers = # value needed
}


modular-magician avatar May 26 '25 11:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 41 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 41 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_folder (5 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_folder" "primary" {
  custom_headers = # value needed
}


modular-magician avatar May 26 '25 11:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 26 '25 13:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 108 Skipped tests: 10 Affected tests: 3

Click here to see the affected service packages
  • storage
#### Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageFolder_DeleteEmptyFolderWithForceDestroyDefault
  • TestAccStorageFolder_hnsDisabled
  • TestAccStorageFolder_storageFolderBasic

Get to know how VCR tests work

modular-magician avatar May 26 '25 13:05 modular-magician

🔴 Tests failed during RECORDING mode: TestAccStorageFolder_DeleteEmptyFolderWithForceDestroyDefault [Error message] [Debug log] TestAccStorageFolder_hnsDisabled [Error message] [Debug log] TestAccStorageFolder_storageFolderBasic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar May 26 '25 13:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 41 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 41 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_folder (5 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_folder" "primary" {
  custom_headers = # value needed
}


modular-magician avatar May 26 '25 13:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 49 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 49 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

modular-magician avatar May 26 '25 14:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 26 '25 15:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 26 '25 15:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 49 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 49 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

modular-magician avatar May 29 '25 07:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 44 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 5 files changed, 44 insertions(+), 3 deletions(-))

modular-magician avatar May 29 '25 08:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 44 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 5 files changed, 44 insertions(+), 3 deletions(-))

modular-magician avatar May 29 '25 08:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 29 '25 08:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 29 '25 09:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 29 '25 10:05 modular-magician

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar May 29 '25 10:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-))

modular-magician avatar May 30 '25 05:05 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar May 30 '25 06:05 modular-magician

Hi @gurusai-voleti, Please hold this PR until we get decision for every storage resource.

kautikdk avatar May 30 '25 13:05 kautikdk

converting to draft for now in accordance with the above comment

ScottSuarez avatar May 30 '25 17:05 ScottSuarez

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-))

modular-magician avatar Jun 04 '25 07:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 5 files changed, 43 insertions(+), 3 deletions(-))

modular-magician avatar Jun 04 '25 08:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_storage_folder
    • Expected Document Path: /website/docs/r/storage_folder.html.markdown
    • Fields: [custom_headers]

modular-magician avatar Jun 04 '25 08:06 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar Jun 04 '25 09:06 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar Jun 04 '25 09:06 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar Jun 04 '25 09:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_storage_folder
    • Expected Document Path: /website/docs/r/storage_folder.html.markdown
    • Fields: [custom_headers]

modular-magician avatar Jun 04 '25 10:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-))

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_storage_folder
    • Expected Document Path: /website/docs/r/storage_folder.html.markdown
    • Fields: [custom_headers]

modular-magician avatar Jun 04 '25 10:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 39 insertions(+), 2 deletions(-))

modular-magician avatar Jun 04 '25 11:06 modular-magician

Tests analytics

Total tests: 121 Passed tests: 111 Skipped tests: 10 Affected tests: 0

Click here to see the affected service packages
  • storage
🟢 All tests passed!

View the build log

modular-magician avatar Jun 04 '25 12:06 modular-magician