magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add detect tool for unlinked tmpl

Open iyabchen opened this issue 8 months ago • 11 comments

https://github.com/hashicorp/terraform-provider-google/issues/19652

Part 1: Refactor: https://github.com/GoogleCloudPlatform/magic-modules/pull/14297 Part 2: Add detection for unlinked templates (current)

Tested in https://github.com/GoogleCloudPlatform/magic-modules/pull/13803

Unit test did not cover the run function since it depends on some folder structure.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


iyabchen avatar Apr 28 '25 10:04 iyabchen

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Apr 28 '25 10:04 modular-magician

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 02 '25 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 06 '25 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 13 '25 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 20 '25 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 27 '25 09:05 github-actions[bot]

@iyabchen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 16 '25 09:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jun 18 '25 00:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jun 18 '25 01:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jun 18 '25 01:06 modular-magician

@shuyama1, since there is a new check for large PR, I split this into 2 parts, and move part 1 to https://github.com/GoogleCloudPlatform/magic-modules/pull/14297. So after part 1 can be merged, I will rebase and see whether this PR can pass that PR size check.

iyabchen avatar Jun 18 '25 02:06 iyabchen

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jun 24 '25 22:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jul 07 '25 17:07 modular-magician

/gcbrun

shuyama1 avatar Jul 15 '25 19:07 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Jul 15 '25 20:07 modular-magician

/gcbrun

shuyama1 avatar Sep 03 '25 17:09 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Sep 03 '25 18:09 modular-magician

Major release is out. Merging of this PR should be unblocked now. Planning to merge this PR today.

shuyama1 avatar Sep 03 '25 18:09 shuyama1

/gcbrun

shuyama1 avatar Sep 17 '25 21:09 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Sep 17 '25 21:09 modular-magician