add principal access boundary policy resource. Fixes https://github.com/hashicorp/terraform-provider-google/issues/19905

[derekchu-google]

Release Note Template for Downstream PRs (will be copied)

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  details {
    enforcement_version = # value needed
    rules {
      description = # value needed
      effect      = # value needed
      resources   = # value needed
    }
  }
  etag = # value needed
}

Errors

google provider:

• Failed to build branch auto-pr-12044-old

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[rileykarson]

/gcbrun

[modular-magician]

Tests analytics

Total tests: 4198 Passed tests: 3775 Skipped tests: 418 Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccDataLossPreventionDiscoveryConfig_Update
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1379 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log] TestAccDataLossPreventionDiscoveryConfig_Update[Debug log] 🔴 Tests failed when rerunning REPLAYING mode: TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[derekchu-google]

still WIP. please hold off on review. thanks!

[modular-magician]

Tests analytics

Total tests: 4198 Passed tests: 3776 Skipped tests: 418 Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
• TestAccDataLossPreventionDiscoveryConfig_Update
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1345 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 1350 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log] TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 4198 Passed tests: 3776 Skipped tests: 418 Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
• TestAccDataLossPreventionDiscoveryConfig_Update
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[derekchu-google]

🟢 Tests passed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log] TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

i tested with my own project/organization. this command is hidden behind a visibility label so I impersonated with a service account which has the proper permissions. im not sure how to reflect this testing setup in these PR tests.

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log] TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 4200 Passed tests: 3778 Skipped tests: 420 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 4200 Passed tests: 3777 Skipped tests: 420 Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample[Error message] [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions[bot]]

@SarahFrench This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 1350 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4208 Passed tests: 3786 Skipped tests: 420 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample
• TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample [Debug log] TestAccIAM3PrincipalAccessBoundaryPolicy_iam3PrincipalAccessBoundaryPolicyExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[derekchu-google]

Fixes hashicorp/terraform-provider-google#19905

Release Note Template for Downstream PRs (will be copied)

`google_iam3_principal_access_boundary_policy`

Thank you for the edit

[derekchu-google]

sorry hit the wrong button and closed it by accident

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 15 files changed, 1350 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 13 files changed, 1340 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam3_principal_access_boundary_policy (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_iam3_principal_access_boundary_policy" "primary" {
  annotations = # value needed
  etag        = # value needed
}

[modular-magician]

Tests analytics

Total tests: 4209 Passed tests: 3774 Skipped tests: 420 Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate
• TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekExample
• TestAccCloudRunService_cloudRunServiceSqlExample
• TestAccCloudRunV2Job_cloudrunv2JobSqlExample
• TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample
• TestAccDataLossPreventionDiscoveryConfig_Update
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample
• TestAccDatabaseMigrationServiceMigrationJob_update
• TestAccSqlDatabaseInstance_Edition_Downgrade

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccBackupDRBackupVault_fullUpdate [Debug log] TestAccBigqueryConnectionConnection_bigqueryConnectionSqlWithCmekExample [Debug log] TestAccCloudRunService_cloudRunServiceSqlExample [Debug log] TestAccCloudRunV2Job_cloudrunv2JobSqlExample [Debug log] TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample [Debug log] TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample [Debug log] TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample [Debug log] TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample [Debug log] TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample [Debug log] TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample [Debug log] TestAccDatabaseMigrationServiceMigrationJob_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode: TestAccCloudRunV2Service_cloudrunv2ServiceSqlExample [Error message] [Debug log] TestAccDataLossPreventionDiscoveryConfig_Update [Error message] [Debug log] TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample [Error message] [Debug log] TestAccSqlDatabaseInstance_Edition_Downgrade [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[derekchu-google]

👋🏻 Hi, thanks for your PR!

From looking at the API documentation I believe this resource would be in the google-beta provider but not the google provider, so I've made some suggested changes based on that. Is my understanding correct?

hi Sarah! thanks for the comments. this resource today is in public preview so yes, you're correct it's a v3beta which would then be google-beta. that being said, terraform support is only targeted for our GA so that's why we're not doing a google-beta. the tricky part is for this PR to get approved and wait until a week before we remove the visibility restriction.

that being said, i do wonder if we should just push a google-beta out first and have that available....

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 276 insertions(+)) google-beta provider: Diff ( 13 files changed, 1354 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 180 insertions(+))