magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Added google_apigee_api resource

Open apichick opened this issue 1 year ago • 1 comments

This is a PR to add the google_apigee_api resource

`google_apigee_api`

apichick avatar Oct 17 '24 09:10 apichick

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Oct 17 '24 09:10 github-actions[bot]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 22 '24 09:10 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 944 insertions(+), 74 deletions(-)) google-beta provider: Diff ( 9 files changed, 944 insertions(+), 74 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_api (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_api" "primary" {
  detect_md5hash = # value needed
}


modular-magician avatar Oct 22 '24 15:10 modular-magician

Tests analytics

Total tests: 48 Passed tests: 14 Skipped tests: 34 Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeApi_apigeeApiTestExample 🟢 All tests passed!

View the build log

modular-magician avatar Oct 22 '24 15:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 962 insertions(+), 74 deletions(-)) google-beta provider: Diff ( 9 files changed, 962 insertions(+), 74 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_api (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_api" "primary" {
  detect_md5hash = # value needed
}


modular-magician avatar Oct 30 '24 16:10 modular-magician

Tests analytics

Total tests: 48 Passed tests: 14 Skipped tests: 34 Affected tests: 0

Click here to see the affected service packages
  • apigee
#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccApigeeApi_apigeeApiTestExample 🟢 All tests passed!

View the build log

modular-magician avatar Oct 30 '24 16:10 modular-magician

There is some documentation issue , Example is provided for google_apigee_sharedflow instead of google_apigee_api image

mahek-cldcvr avatar Jan 30 '25 13:01 mahek-cldcvr

md5 not working, have bundle same name, md5 different, but google_apigee_api not trigger update. md5hash base64 seems wrong "terraform_version": "1.9.0" "google-beta": "6.23.0"

  {
      "index_key": "test-to-<REDACTED>-prd",
      "schema_version": 0,
      "attributes": {
        "config_bundle": "./temp/test-to-<REDACTED>-prd.zip",
        "detect_md5hash": "UVMpfEhJnZ06kkhywXKymg==",
        "id": "organizations/<REDACTED>/apis/test-to-<REDACTED>-prd",
        "latest_revision_id": "",
        "md5hash": "UVMpfEhJnZ06kkhywXKymg==",
        "meta_data": [{
          "created_at": "1740712271425",
          "last_modified_at": "1740902593940",
          "sub_type": "Proxy"
        }],
        "name": "<REDACTED>",
        "org_id": "<REDACTED>",
        "revision": ["1", "2", "3", "4"],
        "timeouts": null
      },
      "sensitive_attributes": [],
      "private": "<REDACTED>",
      "dependencies": ["archive_file.proxy_folders", "null_resource.always_run"]
    }

shawnsavour avatar Mar 02 '25 08:03 shawnsavour

@shawnsavour please file an issue against https://github.com/terraform-providers/terraform-provider-google

slevenick avatar Mar 05 '25 16:03 slevenick