magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

fix: remove retry in read as retry for create/update is already handled in respective methods

Open gurusai-voleti opened this issue 1 year ago • 8 comments

remove retry in read as retry for create/update is already handled in respective methods

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/13464

Release Note Template for Downstream PRs (will be copied)

storage: removed retry on 404s during refresh for `google_storage_bucket`, preventing hanging when refreshing deleted buckets

gurusai-voleti avatar Oct 17 '24 05:10 gurusai-voleti

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Oct 17 '24 05:10 github-actions[bot]

What bug(s) is this addressing / what's the context?

rileykarson avatar Oct 17 '24 18:10 rileykarson

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-)) google-beta provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-))

modular-magician avatar Oct 18 '24 03:10 modular-magician

Tests analytics

Total tests: 109 Passed tests: 100 Skipped tests: 9 Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

modular-magician avatar Oct 18 '24 04:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-)) google-beta provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-))

modular-magician avatar Oct 21 '24 06:10 modular-magician

Tests analytics

Total tests: 109 Passed tests: 100 Skipped tests: 9 Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

modular-magician avatar Oct 21 '24 07:10 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 21 '24 09:10 github-actions[bot]

Hi @gurusai-voleti, As per the changes, we are planning to remove retry logic for read operations. Are we ensured that it is matching storage buckets SLOs? If not can we consider shorter retry time?

kautikdk avatar Oct 21 '24 10:10 kautikdk

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-)) google-beta provider: Diff ( 1 file changed, 1 insertion(+), 10 deletions(-))

modular-magician avatar Oct 22 '24 05:10 modular-magician

Tests analytics

Total tests: 109 Passed tests: 100 Skipped tests: 9 Affected tests: 0

Click here to see the affected service packages
  • storage

🟢 All tests passed!

View the build log

modular-magician avatar Oct 22 '24 05:10 modular-magician