Mc parameterized

[nehalk-tf]

Release Note Template for Downstream PRs (will be copied)

PRODUCT: added `parameters` fields to `policy` resource (beta)

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 35 insertions(+)) google-beta provider: Diff ( 2 files changed, 126 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 8 Passed tests: 8 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• orgpolicy

🟢 All tests passed!

View the build log

[github-actions[bot]]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

running the build

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 63 insertions(+)) google-beta provider: Diff ( 3 files changed, 154 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 8 Passed tests: 8 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• orgpolicy

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+)) google-beta provider: Diff ( 3 files changed, 231 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[c2thorn]

reassigning inprogress PR for while I'm out @rileykarson feel free to reassign as needed

Should just need iterations until tests pass, not sure why the magician thinks the fields aren't covered in the handwritten tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+)) google-beta provider: Diff ( 3 files changed, 231 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (9 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 140 insertions(+)) google-beta provider: Diff ( 3 files changed, 231 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_org_policy_policy (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_org_policy_policy" "primary" {
  dry_run_spec {
    rules {
      parameters = # value needed
    }
  }
  spec {
    rules {
      parameters = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+)) google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[rileykarson]

You'll want to iterate locally (https://googlecloudplatform.github.io/magic-modules/develop/test/run-tests/#optional-test-manually) on formatting the jsonencode properly, I don't remember the way to specify non-strings offhand.

[github-actions[bot]]

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+)) google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @c2thorn This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+)) google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))

[modular-magician]

Tests analytics

Total tests: 10 Passed tests: 8 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• orgpolicy

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy
• TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccOrgPolicyPolicy_EnforceParameterizedMCDryRunPolicy [Error message] [Debug log] TestAccOrgPolicyPolicy_EnforceParameterizedMCPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 131 insertions(+)) google-beta provider: Diff ( 3 files changed, 222 insertions(+), 10 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 39 insertions(+))