GoogleCloudPlatform
Add support for IPv6 addresses with the google_compute_external_vpn_gateway terraform resource
compute: added `interface.ipv6-address` field in `google_compute_external_vpn_gateway` resource
As per the design doc, go/arcus-outer-vpn-ipv6. The support for IPv6 is present for Outer HA VPN, and support for IPV6 address is present in the api implementation and gcloud for external_vpn_gateway. I see the field, ipv6_address which is the IPv6 address of the interface in the external VPN gateway, Is missing in the terraform implementation for external vpn gateway. Adding the missing ipv6_address field in the yaml file.
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_compute_external_vpn_gateway (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_compute_external_vpn_gateway" "primary" {
interface {
ipv6_address = # value needed
}
}
Tests analytics
Total tests: 1029 Passed tests: 954 Skipped tests: 74 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeExternalVPNGateway_insertIpv6Address
Get to know how VCR tests work
🔴 Tests failed during RECORDING mode:
TestAccComputeExternalVPNGateway_insertIpv6Address[Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Tests analytics
Total tests: 1037 Passed tests: 963 Skipped tests: 73 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeExternalVPNGateway_insertIpv6Address
Get to know how VCR tests work
🔴 Tests failed during RECORDING mode:
TestAccComputeExternalVPNGateway_insertIpv6Address [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Tests analytics
Total tests: 1037 Passed tests: 963 Skipped tests: 73 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeExternalVPNGateway_insertIpv6Address
Get to know how VCR tests work
🔴 Tests failed during RECORDING mode:
TestAccComputeExternalVPNGateway_insertIpv6Address [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 77 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Tests analytics
Total tests: 1041 Passed tests: 965 Skipped tests: 73 Affected tests: 3
Click here to see the affected service packages
- compute
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeExternalVPNGateway_insertIpv6Address
- TestAccComputeInstanceConfidentialInstanceConfigMain
- TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccComputeExternalVPNGateway_insertIpv6Address [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test