Fix deletion_protection fields specified as strings
Part of https://github.com/hashicorp/terraform-provider-google/issues/19747
These happen to work because of Terraform's particularly aggressive type coercion, but our docs should specify the true types where possible. This will turn some entries from "" to `` (blank). Working on correcting for those in a followup change, I'll probably gate submission of this on finishing those (and merging both PRs independently will have no merge conflicts, but combine to correct all the pages due to a helpful-for-once cross merge).
I thought these might have been introduced during the Go rewrite, but turns out they werent! They were like that in Ruby too.
Release Note Template for Downstream PRs (will be copied)
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 42 files changed, 102 insertions(+), 104 deletions(-))
google-beta provider: Diff ( 45 files changed, 105 insertions(+), 107 deletions(-))
Open in Cloud Shell: Diff ( 25 files changed, 25 insertions(+), 26 deletions(-))
Tests analytics
Total tests: 1506 Passed tests: 1310 Skipped tests: 196 Affected tests: 0
Click here to see the affected service packages
- firebasehosting
- privateca
- cloudrunv2
- sql
- dns
- bigtable
- compute
- dataprocmetastore
- gkebackup
- gkehub
- spanner
- bigqueryconnection
- datastream
- gkehub2
- cloudrun
🟢 All tests passed!
View the build log
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 42 files changed, 102 insertions(+), 104 deletions(-))
google-beta provider: Diff ( 45 files changed, 105 insertions(+), 107 deletions(-))
Open in Cloud Shell: Diff ( 25 files changed, 25 insertions(+), 26 deletions(-))
Tests analytics
Total tests: 1522 Passed tests: 1324 Skipped tests: 197 Affected tests: 1
Click here to see the affected service packages
- gkehub
- gkehub2
- spanner
- bigqueryconnection
- bigtable
- gkebackup
- cloudrunv2
- datastream
- privateca
- compute
- dataprocmetastore
- firebasehosting
- sql
- cloudrun
- dns
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccSqlDatabaseInstance_Edition_Downgrade
🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_Edition_Downgrade [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
TestAccSqlDatabaseInstance_Edition_Downgrade was broken in another change. Will resolve in a separate PR.
I have the other PR staged; it'll get merged by the next website publish, so gonna merge.