magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update gemfile references to refer to legacy ruby branch

Open NickElliot opened this issue 1 year ago • 1 comments

Part 1 of ruby removals

Release Note Template for Downstream PRs (will be copied)


NickElliot avatar Oct 09 '24 17:10 NickElliot

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Oct 09 '24 17:10 modular-magician

@NickElliot, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Oct 23 '24 09:10 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

modular-magician avatar Oct 24 '24 20:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

modular-magician avatar Oct 24 '24 20:10 modular-magician

Tests analytics

Total tests: 1039 Passed tests: 966 Skipped tests: 73 Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

modular-magician avatar Oct 24 '24 21:10 modular-magician

Followed the testing steps mentioned and the testing image is referenced in the execution details.

Believe it would involve undoing the "testing" reference before this is merged, and pushing up the image to the base but will verify first

NickElliot avatar Oct 24 '24 21:10 NickElliot

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Oct 24 '24 21:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+))

modular-magician avatar Oct 24 '24 21:10 modular-magician