Update forward_ssh_connectivity.private_key to be mutable

[ari-hacks]

This prevents the connection profile from failing permanently (needing to be re-created) when the forward ssh connectivity private key is updated. Fixes https://github.com/hashicorp/terraform-provider-google/issues/18999

Release Note Template for Downstream PRs (will be copied)

datastream: updated `private_key`to be mutable in `google_datastream_connection_profile` resource.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[ari-hacks]

I can see you've been pretty thorough with your change, but the test still needs some work. I would really suggest creating a new test instead of adding to TestAccDatastreamConnectionProfile_update, but I think it could still technically work.

Here's what likely needs to change:

• acctest.SkipIfVcr(t) would need to be removed so the test is run in the PR
• RandSSHKeyPair() won't work because it will be random on every run (see mmv1/third_party/terraform/acctest/test_utils.go.tmpl), so you would need to wrap it. I would suggest just using RandString (or hard-coded keys) unless that causes issues for some reason.

Thanks @roaks3! Sorry for the delay on this. Can you explain how this works a bit more, I'm not too familiar with go test/how it runs in the PR. I see all the test steps are wrapped in VcrTest. Does that means without SkipIfVcr(t) those test should run?

To get this working without too much of a lift what if we:

• decouple this test from the other ones with your suggestion of creating a new test - I believe this would need a separate file? resource_datastream_connection_profile_frwd_ssh_test.go
• RandString() doesn't support the key format for SSH so I can hard code a random private/public key pair

[github-actions[bot]]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@ari-hacks, this PR is being closed due to inactivity.