magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Split test step in acc test for `impersonate_service_account`

Open SarahFrench opened this issue 1 year ago • 9 comments

This was prompted by https://github.com/hashicorp/terraform-provider-google/issues/19741 but isn't related as the failing test is for impersonate_service_account_delegates not impersonate_service_account

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Oct 03 '24 20:10 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 11 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 11 insertions(+), 2 deletions(-))

modular-magician avatar Oct 03 '24 20:10 modular-magician

Tests analytics

Total tests: 4138 Passed tests: 3716 Skipped tests: 416 Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGoogleQuotaInfos_basic
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

modular-magician avatar Oct 03 '24 21:10 modular-magician

🟢 Tests passed during RECORDING mode: TestAccDataSourceGoogleQuotaInfos_basic[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode: TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log] TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log] TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log] TestAccDataformRepository_updated[Error message] [Debug log] TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Oct 03 '24 22:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-))

modular-magician avatar Oct 04 '24 11:10 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 22 insertions(+), 2 deletions(-))

modular-magician avatar Oct 04 '24 11:10 modular-magician

Tests analytics

Total tests: 4138 Passed tests: 3717 Skipped tests: 416 Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

modular-magician avatar Oct 04 '24 13:10 modular-magician

Tests analytics

Total tests: 4138 Passed tests: 3716 Skipped tests: 416 Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

modular-magician avatar Oct 04 '24 13:10 modular-magician

🔴 Tests failed during RECORDING mode: TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log] TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log] TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log] TestAccDataformRepository_updated[Error message] [Debug log] TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Oct 04 '24 13:10 modular-magician

🟢 Tests passed during RECORDING mode: TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode: TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log] TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log] TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log] TestAccDataformRepository_updated[Error message] [Debug log] TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician avatar Oct 04 '24 13:10 modular-magician

Closing as this test hasn't been failing in nightly tests

SarahFrench avatar Oct 22 '24 19:10 SarahFrench