Adding replication field for Filestore Instance

[NA2047]

Adding replication field for resource_filestore_instance

Release Note Template for Downstream PRs (will be copied)

release-note:enhancement Adding replication field to resource_filestore_instance

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 322 insertions(+)) google-beta provider: Diff ( 3 files changed, 322 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (19 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  replication {
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 13 Passed tests: 12 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 322 insertions(+)) google-beta provider: Diff ( 3 files changed, 322 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (19 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  replication {
    role = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 322 insertions(+)) google-beta provider: Diff ( 3 files changed, 322 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (19 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  replication {
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 13 Passed tests: 12 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 13 Passed tests: 12 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[rileykarson]

internal discussion / context

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 610 insertions(+)) google-beta provider: Diff ( 3 files changed, 610 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_deletionProtection_update
• TestAccFilestoreInstance_replication
• TestAccFilestoreInstance_reservedIpRange_update
• TestAccFilestoreInstance_update 🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 757 insertions(+)) google-beta provider: Diff ( 3 files changed, 757 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  effective_replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
  initial_replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 757 insertions(+)) google-beta provider: Diff ( 3 files changed, 757 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 95 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  effective_replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
  initial_replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_deletionProtection_update
• TestAccFilestoreInstance_replication
• TestAccFilestoreInstance_reservedIpRange_update
• TestAccFilestoreInstance_update 🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_deletionProtection_update
• TestAccFilestoreInstance_replication
• TestAccFilestoreInstance_reservedIpRange_update
• TestAccFilestoreInstance_update 🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 530 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 530 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  initial_replication {
    replicas {
      peer_instance = # value needed
    }
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_deletionProtection_update
• TestAccFilestoreInstance_replication
• TestAccFilestoreInstance_reservedIpRange_update
• TestAccFilestoreInstance_update 🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 244 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 242 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  initial_replication {
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 15 Passed tests: 14 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 244 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 242 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  initial_replication {
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 15 Passed tests: 14 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 242 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 242 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_filestore_instance (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_filestore_instance" "primary" {
  initial_replication {
    role = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 15 Passed tests: 14 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_replication

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🔴 Tests failed during RECORDING mode: TestAccFilestoreInstance_replication [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 298 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 4 files changed, 298 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 17 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• filestore

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccFilestoreInstance_replication 🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log