magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

StorageTransfer Service: Support FederatedIdentifyConfig for Azure Blob Storage

Open venky999 opened this issue 1 year ago • 5 comments

Release Note Template for Downstream PRs (will be copied)

Support FederatedIdentifyConfig in StorageTransfer Service for Azure Blob Storage Fixes https://github.com/hashicorp/terraform-provider-google/issues/19526

Note: Will work after merging https://github.com/googleapis/google-api-go-client/pull/2810

venky999 avatar Oct 02 '24 16:10 venky999

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Oct 02 '24 16:10 github-actions[bot]

Can you add a test that specifies this?

I dont see any tests for azure blob storage for other usecases, so I have not added thinking that the test might fail ..

venky999 avatar Oct 04 '24 10:10 venky999

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Oct 09 '24 09:10 github-actions[bot]

Ah, it looks like we need to wait on the go client to be merged to be able to test

slevenick avatar Oct 09 '24 15:10 slevenick

Ah, it looks like we need to wait on the go client to be merged to be able to test

Yes I raised a PR https://github.com/googleapis/google-api-go-client/pull/2810 but its closed as its a copy. looks like it needs to be done from google side

venky999 avatar Oct 09 '24 15:10 venky999

@venky999, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Oct 23 '24 09:10 github-actions[bot]

@venky999, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Nov 06 '24 09:11 github-actions[bot]

@venky999, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Nov 18 '24 09:11 github-actions[bot]

@venky999, this PR is being closed due to inactivity.

github-actions[bot] avatar Nov 20 '24 09:11 github-actions[bot]