magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add tags field to Spanner Instance for TagsR2401

Open SamanthaMathews opened this issue 1 year ago • 7 comments

Add tags field to instance resource to allow setting tags on instance resources at creation time. Part of b/337048159

Release Note Template for Downstream PRs (will be copied)

Spanner: added `tags` field to `spanner_instance` to allow setting tags for instance at creation time

SamanthaMathews avatar Sep 30 '24 07:09 SamanthaMathews

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 30 '24 07:09 google-cla[bot]

@SarahFrench , could you please provide the approval for running automated test?

SamanthaMathews avatar Sep 30 '24 12:09 SamanthaMathews

I just approved the tests to run. Also, please take a look at the CLA issue!

SarahFrench avatar Sep 30 '24 15:09 SarahFrench

/gcbrun

SamanthaMathews avatar Oct 01 '24 13:10 SamanthaMathews

There is a merge conflict that prevents the automation running tests- please resolve them and I can trigger the tests for you. If you'd like to trigger the tests yourself please see here.

SarahFrench avatar Oct 01 '24 14:10 SarahFrench

@SarahFrench The merge conflicts are resolved

SamanthaMathews avatar Oct 01 '24 15:10 SamanthaMathews

/gcbrun

SamanthaMathews avatar Oct 02 '24 17:10 SamanthaMathews