GoogleCloudPlatform
Support prodcuer port in network endpoint group
Release Note Template for Downstream PRs (will be copied)
compute: added the `psc_data` field to the `google_compute_region_network_endpoint_group` resource
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 35 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 35 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_compute_region_network_endpoint_group (22 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_compute_region_network_endpoint_group" "primary" {
psc_data = # value needed
}
Tests analytics
Total tests: 1015 Passed tests: 940 Skipped tests: 74 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 1015 Passed tests: 940 Skipped tests: 74 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test
@ericlin0101, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.
Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
This notification can be disabled with the disable-automatic-closure label.
@ericlin0101, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.
Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
This notification can be disabled with the disable-automatic-closure label.
@SarahFrench, I believe this is ready to merge. Please proceed with the merge at your convenience. Thank you!
Just realised I hadn't approved the build - I'll let that complete before merging
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 99 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 3 files changed, 100 insertions(+), 13 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 1064 Passed tests: 990 Skipped tests: 73 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
Get to know how VCR tests work
🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
That test is failing on multiple PRs and isn't specific to this PR. Reported that here: https://github.com/hashicorp/terraform-provider-google/issues/17838#issuecomment-2494512276
Approving & merging!
After switching to 6.13.0 I started to get constant recreation of my NEGs. I tried to recreate them once with 6.13.0 version but it keeps showing the "recreate" action on new plans. There was no code changes on my side and I also didn't add psc_data field since it's optional and I don't need it. I had to stick to 6.12.0 version to get this issue disappear. Is this a bug of the optional psc_data field?
Hi @RomanPavelkoMGM - comments on closed PRs will not go through our triage process. Please open an issue referencing this PR if you're having a problem. Thanks!