Change update method for `boot_disk.auto_delete` on `google_compute_instance`

[karolgorc]

closes https://github.com/hashicorp/terraform-provider-google/issues/14707

This will prevent recreating the VM when changing auto_delete parameter

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_instance` is no longer recreated when changing `boot_disk.auto_delete`

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions[bot]]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

Hi @karolgorc, I've found that you have many open pull requests for Magic Modules, and wanted to reach you about the upcoming language migration. I've randomly picked this pull request to comment on.

You can view the details of the language migration here: https://github.com/hashicorp/terraform-provider-google/issues/19583

Later this week many of your pull requests may become incompatible due to the template files changing from Ruby (.erb) to Go (.tmpl) templates. Our team (Magic Modules repository maintainers) has some tooling to automatically convert changes to the new language, and we can prepare a converted commit for all of your open pull requests.

However, this converted commit will be rebased to a commit after the migration. This means in order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event anything went wrong or needs additional changes.

Of course, you also have the option to convert your pull requests yourself after the migration tomorrow. We have links to a preview branch and updated documentation in the link above.

As an owner of many open pull requests, what would you like to do? Do we have your permission to push commits to your fork's branches, or would you like to convert them yourself?

Let me know if you have any questions or if there is a better method to converse.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[c2thorn]

@karolgorc please see this comment: https://github.com/GoogleCloudPlatform/magic-modules/pull/11742#issuecomment-2372005694

If you would like assistance converting files, we need your permission to push changes to this branch.

[karolgorc]

Hi @c2thorn.

Thanks for the info. I see that the changes are already live. The branches affected are

• auto-delete-update
• resource-policies-diff
• key-revocation-action-field
• min-cpu-platform-error-message
• remove-hardcoded-values-instance-template

You can force-push to the fork. Do you need me to do something in order for this to work?

[c2thorn]

Hi @c2thorn.

Thanks for the info. I see that the changes are already live. The branches affected are

• auto-delete-update
• resource-policies-diff
• key-revocation-action-field
• min-cpu-platform-error-message
• remove-hardcoded-values-instance-template

You can force-push to the fork. Do you need me to do something in order for this to work?

Thanks @karolgorc! If things go smoothly, you won't have to do anything. But to help in the case we need to restore your branch from our backups, could you add me (c2thorn) as collaborator to your fork here: https://github.com/karolgorc/magic-modules/settings

[karolgorc]

done

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[KevsAlex]

is this still in review or was it solved in some version ?

[github-actions[bot]]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[nightpool]

Would love to see this get merged!

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[karolgorc]

Hi can this get reviewed or reassigned?

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

Reassigning to @slevenick

Also /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 93 insertions(+), 13 deletions(-)) google-beta provider: Diff ( 2 files changed, 93 insertions(+), 13 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance_from_machine_image (12 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  boot_disk {
    auto_delete = # value needed
  }
}

Resource: google_compute_instance_from_template (20 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  boot_disk {
    auto_delete = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 1070 Passed tests: 996 Skipped tests: 73 Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstance_autoDeleteUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode: TestAccComputeInstance_autoDeleteUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test