feat: add location certificate map and entry

[adriantr]

Solves https://github.com/hashicorp/terraform-provider-google/issues/19437

Release Note Template for Downstream PRs (will be copied)

certificatemanager: added `location` field to `google_certificate_manager_certificate_map` resource

certificatemanager: added `location` field to `google_certificate_manager_certificate_map_entry` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[adriantr]

@rileykarson hey, any take on this PR?🙏

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 64 insertions(+), 42 deletions(-)) google-beta provider: Diff ( 8 files changed, 64 insertions(+), 42 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_certificate_manager_certificate_map (7 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_certificate_manager_certificate_map" "primary" {
  location = # value needed
}

Resource: google_certificate_manager_certificate_map_entry (5 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_certificate_manager_certificate_map_entry" "primary" {
  location = # value needed
}

[modular-magician]

Tests analytics

Total tests: 26 Passed tests: 0 Skipped tests: 2 Affected tests: 24

Click here to see the affected service packages

• certificatemanager

Action taken

Found 24 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample
• TestAccCertificateManagerCertificateMapEntry_certificateManagerCertificateMapEntryFullExample
• TestAccCertificateManagerCertificateMap_certificateManagerCertificateMapBasicExample
• TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsAllRegionsExample
• TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample
• TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigAllRegionsExample
• TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample
• TestAccCertificateManagerCertificate_certificateManagerGoogleManagedRegionalCertificateDnsAuthExample
• TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample
• TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateRegionalExample
• TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample
• TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationRegionalExample
• TestAccCertificateManagerDnsAuthorization_update
• TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigAllowlistedCertificatesExample
• TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample
• TestAccCertificateManagerTrustConfig_update
• TestAccDataSourceGoogleCertificateManagerCertificateMap_basic
• TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource
• TestAccDataSourceGoogleCertificateManagerCertificates_basic
• TestAccDataSourceGoogleCertificateManagerCertificates_full
• TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificate
• TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificateDNSAuthorization
• TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificateIssuerConfig
• TestAccDataSourceGoogleCertificateManagerCertificates_regionBasic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample[Error message] [Debug log] TestAccCertificateManagerCertificateMapEntry_certificateManagerCertificateMapEntryFullExample[Error message] [Debug log] TestAccCertificateManagerCertificateMap_certificateManagerCertificateMapBasicExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsAllRegionsExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateDnsExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigAllRegionsExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerGoogleManagedRegionalCertificateDnsAuthExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample[Error message] [Debug log] TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateRegionalExample[Error message] [Debug log] TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample[Error message] [Debug log] TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationRegionalExample[Error message] [Debug log] TestAccCertificateManagerDnsAuthorization_update[Error message] [Debug log] TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigAllowlistedCertificatesExample[Error message] [Debug log] TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample[Error message] [Debug log] TestAccCertificateManagerTrustConfig_update[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificateMap_basic[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificateMap_certificateMapEntryUsingMapDatasource[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_basic[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_full[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificate[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificateDNSAuthorization[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_managedCertificateIssuerConfig[Error message] [Debug log] TestAccDataSourceGoogleCertificateManagerCertificates_regionBasic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions[bot]]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

Sorry- I've been very behind on reviews (and email, so it's taken a bit to identify the ones I need to take action on). Rolled a new reviewer.

[github-actions[bot]]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[Hamzawy63]

Hi @adriantr,

Thanks for your contribution, I hope it gets reviewed soon from Terraform team!

For the issue you mentioned though, I don't think this PR will fix https://github.com/hashicorp/terraform-provider-google/issues/19437 . Please refer to my comment to the issue https://github.com/hashicorp/terraform-provider-google/issues/19437#issuecomment-2413785588 and let me know if you have any questions.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@adriantr, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@adriantr, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@adriantr, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@adriantr, this PR is being closed due to inactivity.