magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add acceptance tests for how provider handles `billing_project` arguments

Open SarahFrench opened this issue 1 year ago • 56 comments

This PR adds acceptance tests for usage of billing_project that demonstrate:

  • how the provider behaves when provider configuration arguments come from different sources ( config vs ENVs)
  • schema-level validation that's in place, e.g. handling of empty arrays
  • use cases: how does this argument impact the providers behaviour in plan/apply
    • I've tested the use of billing_project + user_project_override=false to show that billing_project has no impact then
    • I've tested the use of billing_project + user_project_override=true to show that billing_project does have impact then

NOTE: I added some usage tests for the PF provider, but they should be replaced in future because being limited to Firebase data sources to test the PF provider makes the test very awkward

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Sep 02 '24 18:09 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1275 insertions(+), 734 deletions(-)) google-beta provider: Diff ( 13 files changed, 1275 insertions(+), 734 deletions(-))

modular-magician avatar Sep 02 '24 18:09 modular-magician

Tests analytics

Total tests: 3813 Passed tests: 3402 Skipped tests: 409 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccComputeInstanceTemplate_withNamePrefix

Get to know how VCR tests work

modular-magician avatar Sep 02 '24 19:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log] TestAccComputeInstanceTemplate_withNamePrefix[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 02 '24 19:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1287 insertions(+), 735 deletions(-)) google-beta provider: Diff ( 13 files changed, 1287 insertions(+), 735 deletions(-))

modular-magician avatar Sep 04 '24 17:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1285 insertions(+), 735 deletions(-)) google-beta provider: Diff ( 13 files changed, 1285 insertions(+), 735 deletions(-))

modular-magician avatar Sep 04 '24 18:09 modular-magician

Tests analytics

Total tests: 3875 Passed tests: 3463 Skipped tests: 410 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccComputeInstanceTemplate_withNamePrefix

Get to know how VCR tests work

modular-magician avatar Sep 04 '24 19:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Sep 04 '24 19:09 modular-magician

Tests analytics

Total tests: 3751 Passed tests: 3340 Skipped tests: 408 Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccComputeInstanceTemplate_withNamePrefix
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

modular-magician avatar Sep 04 '24 19:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log] TestAccComputeInstanceTemplate_withNamePrefix[Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 04 '24 19:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 1285 insertions(+), 735 deletions(-)) google-beta provider: Diff ( 13 files changed, 1285 insertions(+), 735 deletions(-))

modular-magician avatar Sep 05 '24 10:09 modular-magician

Tests analytics

Total tests: 3958 Passed tests: 3546 Skipped tests: 411 Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician avatar Sep 05 '24 11:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 05 '24 11:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 320 insertions(+), 342 deletions(-)) google-beta provider: Diff ( 4 files changed, 320 insertions(+), 342 deletions(-))

modular-magician avatar Sep 05 '24 11:09 modular-magician

Tests analytics

Total tests: 3958 Passed tests: 3547 Skipped tests: 411 Affected tests: 0

Click here to see the affected service packages

All service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician avatar Sep 05 '24 12:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 320 insertions(+)) google-beta provider: Diff ( 2 files changed, 320 insertions(+))

modular-magician avatar Sep 24 '24 18:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 316 insertions(+)) google-beta provider: Diff ( 2 files changed, 316 insertions(+))

modular-magician avatar Sep 24 '24 18:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 316 insertions(+)) google-beta provider: Diff ( 2 files changed, 316 insertions(+))

modular-magician avatar Sep 24 '24 18:09 modular-magician

Tests analytics

Total tests: 4100 Passed tests: 3687 Skipped tests: 412 Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician avatar Sep 24 '24 19:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 24 '24 19:09 modular-magician

Tests analytics

Total tests: 4100 Passed tests: 3686 Skipped tests: 412 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample

Get to know how VCR tests work

modular-magician avatar Sep 24 '24 19:09 modular-magician

Tests analytics

Total tests: 4100 Passed tests: 3686 Skipped tests: 412 Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample

Get to know how VCR tests work

modular-magician avatar Sep 24 '24 19:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log] TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 24 '24 20:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log] TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccNetworkConnectivitySpoke_networkConnectivitySpokeVpnTunnelBasicExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 24 '24 20:09 modular-magician

Rebased to include Go rewrite

SarahFrench avatar Sep 26 '24 10:09 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 316 insertions(+)) google-beta provider: Diff ( 2 files changed, 316 insertions(+))

modular-magician avatar Sep 26 '24 10:09 modular-magician

Tests analytics

Total tests: 4101 Passed tests: 3687 Skipped tests: 413 Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician avatar Sep 26 '24 11:09 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Sep 26 '24 11:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 401 insertions(+)) google-beta provider: Diff ( 2 files changed, 401 insertions(+))

modular-magician avatar Sep 30 '24 19:09 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 400 insertions(+)) google-beta provider: Diff ( 2 files changed, 400 insertions(+))

modular-magician avatar Sep 30 '24 19:09 modular-magician

Tests analytics

Total tests: 4114 Passed tests: 3698 Skipped tests: 413 Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewCrossProjectExample

Get to know how VCR tests work

modular-magician avatar Sep 30 '24 20:09 modular-magician