Fix post-6.0.0 TGC issues
Release Note Template for Downstream PRs (will be copied)
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 38 files changed, 80 insertions(+), 13 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
terraform-google-conversion: Diff ( 38 files changed, 80 insertions(+), 13 deletions(-))
Tests analytics
Total tests: 43 Passed tests: 37 Skipped tests: 5 Affected tests: 1
Click here to see the affected service packages
- cloudrunv2
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDataSourceGoogleCloudRunV2Job_basic
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleCloudRunV2Job_basic[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 39 files changed, 82 insertions(+), 13 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 40 files changed, 99 insertions(+), 20 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 40 files changed, 111 insertions(+), 20 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 41 files changed, 125 insertions(+), 24 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 41 files changed, 128 insertions(+), 23 deletions(-))
@melinath @c2thorn Sorry, this PR is still WIP. I'm only adding reviewers to prevent it from assigning reviewers from service teams. I'll mark it as ready for review once all TGC tests have passed.
@melinath It seems that once a service label is added, it remains even if the changes in that service package are reverted. I'm not sure if this is the intended behavior, just want to flag.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 40 files changed, 126 insertions(+), 23 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
terraform-google-conversion: Diff ( 40 files changed, 126 insertions(+), 23 deletions(-))
@melinath It seems that once a service label is added, it remains even if the changes in that service package are reverted. I'm not sure if this is the intended behavior, just want to flag.
yes, this is the intended behavior. More specifically, if any service label is present, the CI pipeline will not modify the service labels. This allows us to do things like manual overrides if necessary.