GoogleCloudPlatform
Refactor muxing 2 : Remove unused code, resulting from #11903
Follow up to https://github.com/GoogleCloudPlatform/magic-modules/pull/11903. Most commits in this PR are in that PR, and will 'disappear' once this PR is unblocked and ready for review.
This PR deletes all the parallel implementations of provider configuration logic. The PR https://github.com/GoogleCloudPlatform/magic-modules/pull/11903 stops the provider using this duplicated logic, and this PR removes that redundant code.
In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.
Release Note Template for Downstream PRs (will be copied)
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 18 files changed, 112 insertions(+), 3955 deletions(-))
google-beta provider: Diff ( 24 files changed, 156 insertions(+), 4161 deletions(-))
Tests analytics
Total tests: 3930 Passed tests: 3519 Skipped tests: 407 Affected tests: 4
Click here to see the affected service packages
All service packages are affected
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeInstanceTemplate_withNamePrefix
- TestAccDataSourceGoogleFirebaseAndroidAppConfig
- TestAccDataSourceGoogleFirebaseAppleAppConfig
- TestAccFirebaseWebApp_firebaseWebAppFull
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
TestAccFirebaseWebApp_firebaseWebAppFull[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 19 files changed, 115 insertions(+), 3956 deletions(-))
google-beta provider: Diff ( 25 files changed, 160 insertions(+), 4174 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 19 files changed, 115 insertions(+), 3956 deletions(-))
google-beta provider: Diff ( 25 files changed, 160 insertions(+), 4174 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 19 files changed, 115 insertions(+), 3956 deletions(-))
google-beta provider: Diff ( 25 files changed, 160 insertions(+), 4174 deletions(-))
Tests analytics
Total tests: 3930 Passed tests: 3521 Skipped tests: 406 Affected tests: 3
Click here to see the affected service packages
All service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeInstanceTemplate_withNamePrefix
- TestAccDataSourceGoogleFirebaseAndroidAppConfig
- TestAccDataSourceGoogleFirebaseAppleAppConfig
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Tests analytics
Total tests: 3930 Passed tests: 3521 Skipped tests: 406 Affected tests: 3
Click here to see the affected service packages
All service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeInstanceTemplate_withNamePrefix
- TestAccDataSourceGoogleFirebaseAndroidAppConfig
- TestAccDataSourceGoogleFirebaseAppleAppConfig
Get to know how VCR tests work
Tests analytics
Total tests: 3930 Passed tests: 3521 Skipped tests: 406 Affected tests: 3
Click here to see the affected service packages
All service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeInstanceTemplate_withNamePrefix
- TestAccDataSourceGoogleFirebaseAndroidAppConfig
- TestAccDataSourceGoogleFirebaseAppleAppConfig
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceGoogleFirebaseAppleAppConfig[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.
Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 19 files changed, 105 insertions(+), 3821 deletions(-))
google-beta provider: Diff ( 25 files changed, 150 insertions(+), 4059 deletions(-))
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
All service packages are affected
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 25 files changed, 171 insertions(+), 3891 deletions(-))
google-beta provider: Diff ( 31 files changed, 215 insertions(+), 4129 deletions(-))
Tests analytics
Total tests: 4139 Passed tests: 3721 Skipped tests: 411 Affected tests: 7
Click here to see the affected service packages
All service packages are affected
Action taken
Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
- TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
- TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
- TestAccDataformRepository_updated
- TestAccDataprocCluster_withAutoscalingPolicy
- TestAccFrameworkProviderBasePath_setBasePath
- TestAccFrameworkProviderMeta_setModuleName
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 5 files changed, 3746 deletions(-))
google-beta provider: Diff ( 5 files changed, 3911 deletions(-))
Tests analytics
Total tests: 4306 Passed tests: 3899 Skipped tests: 405 Affected tests: 2
Click here to see the affected service packages
All service packages are affected
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
- TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
Get to know how VCR tests work
🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
View the build log or the debug log for each test
Thanks, I'll go ahead and merge as I don't think there's a need for multiple approvals here vs the first PR