magic-modules [DO_NOT_MERGE] fix recording upload failure in nightly vcr run

Release Note Template for Downstream PRs (will be copied)

Aug 28 '24 23:08 iyabchen

@shuyama1 I created this branch to test the recording

it disabled fetch recording at replay, to trigger replay failure
it only runs the service/compute
it uploads to a temp folder
include the fix for copy from src + "/*" to destination to see whether that helps.

Could you help setup the trigger?

Aug 28 '24 23:08 iyabchen

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Aug 28 '24 23:08 modular-magician

Done!

@iyabchen you'll also need to modify .ci/gcb-vcr-nightly.yml to use the golang version in this PR, similar to #11148. I'll create a testing trigger after.

Sep 05 '24 00:09 iyabchen

Trigger the testing trigger

/gcbrun

Sep 05 '24 19:09 shuyama1

@iyabchen Hey, I've set up the trigger. The current run is failing, you'll probably need to resolve the merge conflicts first. Any commits to the branch nightly-vcr-test-go-record-fix should trigger the cloud build job automatically. Please let me know if you have any questions.

Sep 05 '24 19:09 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sep 09 '24 17:09 modular-magician

@shuyama1

Tests showed that it can do the recording.
I have reverted the debug code.
Main change is to just print warning when upload failed instead of returning an error.
Some template change to make it print the error if there is any.

Sep 09 '24 19:09 iyabchen

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sep 10 '24 09:09 github-actions[bot]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sep 12 '24 09:09 github-actions[bot]

Just rebased to latest main

Sep 14 '24 01:09 iyabchen

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sep 14 '24 01:09 modular-magician

Sorry for delay, just rebased and force pushed.

Sep 20 '24 17:09 iyabchen

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Sep 20 '24 17:09 modular-magician