Added Filter validation for google_scc_notification_config
TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter api: 'https://cloud.google.com/security-command-center/docs/reference/rest/v1/organizations.notificationConfigs'
Release Note Template for Downstream PRs (will be copied)
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))
Errors
google provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
google-beta provider:
- The diff processor failed to build. This is usually due to the downstream provider failing to compile.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- securitycenter
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 31 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 31 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 14 Passed tests: 13 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- securitycenter
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 31 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 31 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 14 Passed tests: 13 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- securitycenter
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 8 files changed, 155 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 8 files changed, 155 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 32 insertions(+), 12 deletions(-))
Tests analytics
Total tests: 29 Passed tests: 25 Skipped tests: 0 Affected tests: 4
Click here to see the affected service packages
- securitycenter
- securitycenterv2
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter
- TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter
- TestAccSecurityCenterV2OrganizationNotificationConfig_basic
- TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterNotificationConfig_updateStreamingConfigFilter[Debug log]
TestAccSecurityCenterProjectNotificationConfig_updateStreamingConfigFilter[Debug log]
TestAccSecurityCenterV2OrganizationNotificationConfig_basic[Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
one change needed
one change needed
fixed
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 8 files changed, 152 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 8 files changed, 152 insertions(+), 28 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 32 insertions(+), 12 deletions(-))
Tests analytics
Total tests: 30 Passed tests: 30 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- securitycenter
- securitycenterv2
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log