GoogleCloudPlatform
Spoke-changes(Migration from DCL to MMv1)
Migration of Spoke from DCL to Magic-Modules
Migration of Hub from DCL to Magic-Modules
networkconnectivity: migrated `google_network_connectivity_spoke` from DCL to MMv1
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR hasn't generated any diffs, but I'll let you know if a future commit does.
Errors
google provider:
- Failed to clone repo at new branch
- Failed to clone repo at old branch
google-beta provider:
- Failed to clone repo at new branch
- Failed to clone repo at old branch
terraform-google-conversion:
- Failed to clone repo at new branch
- Failed to clone repo at old branch
Open in Cloud Shell:
- Failed to clone repo at new branch
- Failed to clone repo at old branch
@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1519 insertions(+), 763 deletions(-))
google-beta provider: Diff ( 7 files changed, 1448 insertions(+), 743 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
linked_router_appliance_instances.instances.virtual_machinelost its diff suppress function - reference - Field
linked_vpc_network.urilost its diff suppress function - reference - Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- networkconnectivity
Tests were added that are skipped in VCR:
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
linked_router_appliance_instances.instances.virtual_machinelost its diff suppress function - reference- Field
linked_vpc_network.urilost its diff suppress function - reference- Field
projectlost its diff suppress function - referenceIf you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An
override-breaking-changelabel can be added to allow merging.
Can you please check if the diff suppress functions are needed to be added back?
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
Non-exercised tests
Tests were added that are skipped in VCR:
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample Errors occurred during REPLAYING mode. Please fix them to complete your PR.
View the build log
Can you please fix the error?
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:71:4: expected operand, found '}'
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1519 insertions(+), 763 deletions(-))
google-beta provider: Diff ( 7 files changed, 1448 insertions(+), 743 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
linked_router_appliance_instances.instances.virtual_machinelost its diff suppress function - reference - Field
linked_vpc_network.urilost its diff suppress function - reference - Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- networkconnectivity
Tests were added that are skipped in VCR:
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log
Errors occurred during REPLAYING mode. Please fix them to complete your PR.
View the build log
Error
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:7:2: "context" imported and not used
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:8:2: "fmt" imported and not used
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:11:2: "github.com/hashicorp/terraform-plugin-sdk/v2/terraform" imported and not used
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:12:2: "strings" imported and not used
google-beta/services/networkconnectivity/resource_network_connectivity_spoke_test.go:17:2: "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport" imported as transport_tpg and not used
Hi, have removed the extra imports from the test file, hopefully that should fix the error! Additionally have added diff_suppress functions to some of the required fields. In the case of projects, legacy_long_form_project in itself should ideally prevent the diff from happening.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1515 insertions(+), 763 deletions(-))
google-beta provider: Diff ( 7 files changed, 1444 insertions(+), 743 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- networkconnectivity
Tests were added that are skipped in VCR:
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$
View the build log
Added @trodge as the reviewer to check if something is missing for the migration.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1514 insertions(+), 763 deletions(-))
google-beta provider: Diff ( 7 files changed, 1443 insertions(+), 743 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 19 Passed tests: 13 Skipped tests: 0 Affected tests: 6
Click here to see the affected service packages
- networkconnectivity
Action taken
Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1517 insertions(+), 766 deletions(-))
google-beta provider: Diff ( 7 files changed, 1446 insertions(+), 746 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 19 Passed tests: 15 Skipped tests: 0 Affected tests: 4
Click here to see the affected service packages
- networkconnectivity
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1517 insertions(+), 766 deletions(-))
google-beta provider: Diff ( 7 files changed, 1446 insertions(+), 746 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 19 Passed tests: 18 Skipped tests: 0 Affected tests: 1
Click here to see the affected service packages
- networkconnectivity
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 7 files changed, 1517 insertions(+), 766 deletions(-))
google-beta provider: Diff ( 7 files changed, 1446 insertions(+), 746 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 19 Passed tests: 19 Skipped tests: 0 Affected tests: 0
Click here to see the affected service packages
- networkconnectivity
$\textcolor{green}{\textsf{All tests passed!}}$
View the build log
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - referenceIf you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An
override-breaking-changelabel can be added to allow merging.
Hello, @trodge , is this a breaking change?
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - referenceIf you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An
override-breaking-changelabel can be added to allow merging.Hello, @trodge , is this a breaking change?
No, this is a false positive. Diff suppress functions on the project field have no effect because the field is never read from the API.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 8 files changed, 1518 insertions(+), 789 deletions(-))
google-beta provider: Diff ( 9 files changed, 1447 insertions(+), 788 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 299 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 288 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
projectlost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 3861 Passed tests: 3464 Skipped tests: 383 Affected tests: 14
Click here to see the affected service packages
All service packages are affected
Action taken
Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeRouterBgpPeer_routerPeerRouterAppliance
- TestAccComputeRouterNat_AutoNetworkTier
- TestAccComputeRouterNat_withPrivateNatAndEmptyAction
- TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges
- TestAccComputeRouterNat_withPrivateNatAndRules
- TestAccComputeRouterPeer_routerApplianceInstance
- TestAccDataSourceArtifactRegistryDockerImage
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
- TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
- TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
- TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample
- TestAccNetworkServicesLbRouteExtension_update
Get to know how VCR tests work