Migration of Hub from DCL to Magic-Modules

[kalpanda]

Migration of Hub from DCL to Magic-Modules

`google_network_connectivity_hub`

`google_network_connectivity_hub_test`

` Deleted resource_network_connectivity_hub_sweeper.go.erb in magic-modules/mmv1/third_part/terraform/services/networkconnectivity as it is no longer required`

` Deleted resource_network_connectivity_hub_sweeper.go.erb in magic-modules/mmv1/third_part/terraform/services/networkconnectivity as it is no longer required`

` Deleted hub.yaml in magic-modules/tpgtools/overrides/networkconnectivity and networkconnectivity/beta as it is no longer required`

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 620 insertions(+), 415 deletions(-)) google-beta provider: Diff ( 7 files changed, 547 insertions(+), 393 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (10 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  routing_vpcs {
    uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• networkconnectivity

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccNetworkConnectivityHub_BasicHub
• TestAccNetworkConnectivityHub_BasicHubLongForm $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[slevenick]

Error: google-beta/services/networkconnectivity/resource_network_connectivity_hub_test.go:28:29: undefined: testAccCheckNetworkConnectivityHubDestroyProducer

Without examples, the destroy producer function is not being generated. I'd recommend adding an example or copying the format using other DestroyProducer functions. Turning over to @slevenick for review

Yeah, we'll need a mmv1 example to be added so the generated tests work as intended, also for docs!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 671 insertions(+), 339 deletions(-)) google-beta provider: Diff ( 7 files changed, 598 insertions(+), 317 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 109 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  routing_vpcs {
    uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 17 Passed tests: 12 Skipped tests: 0 Affected tests: 5

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityHub_BasicHub
• TestAccNetworkConnectivityHub_BasicHubLongForm
• TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample
• TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
• TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkConnectivityHub_BasicHub[Debug log] TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log] TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkConnectivityHub_BasicHubLongForm[Error message] [Debug log] TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[kalpanda]

"Field project lost its diff suppress function " should ideally be solved by adding legacy_long_form_projects to the top of the yaml, but it doesn't seem to be solving the issue

[kalpanda]

@slevenick @c2thorn please do take a look at the above

[github-actions[bot]]

@slevenick @c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 671 insertions(+), 339 deletions(-)) google-beta provider: Diff ( 7 files changed, 598 insertions(+), 317 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 109 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (10 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  routing_vpcs {
    uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 17 Passed tests: 15 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityHub_BasicHubLongForm
• TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkConnectivityHub_BasicHubLongForm[Error message] [Debug log] TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 669 insertions(+), 339 deletions(-)) google-beta provider: Diff ( 7 files changed, 596 insertions(+), 317 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (7 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  routing_vpcs {
    uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• networkconnectivity

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccNetworkConnectivityHub_BasicHub
• TestAccNetworkConnectivityHub_BasicHubLongForm
• TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[slevenick]

Adding @trodge as reviewer as I'm going to be out

[github-actions[bot]]

@c2thorn @trodge @slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 669 insertions(+), 339 deletions(-)) google-beta provider: Diff ( 7 files changed, 596 insertions(+), 317 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 96 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_hub (11 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_hub" "primary" {
  routing_vpcs {
    uri = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 17 Passed tests: 15 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityHub_BasicHubLongForm
• TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkConnectivityHub_BasicHubLongForm[Debug log] TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[kalpanda]

@trodge please do take a look at the above, thanks!

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team @c2thorn @trodge @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.