GCVE Resource Optimisation for Acceptance Tests

[swamitagupta]

This pull request is a part of the efforts to reduce Vmwareengine resource usage in Terraform acceptance tests without facing a resource - time tradeoff. The same is further described at go/gcve-resource-optimisation-for-tf-tests.

Release Note Template for Downstream PRs (will be copied)

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-)) google-beta provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 8 Skipped tests: 2 Affected tests: 4

Click here to see the affected service packages

• vmwareengine

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate|TestAccVmwareengineNetworkPeering_update|TestAccVmwareengineNetworkPolicy_update|TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccVmwareengineNetwork_vmwareEngineNetworkUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log] TestAccVmwareengineNetworkPeering_update[Error message] [Debug log] TestAccVmwareengineNetworkPolicy_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-)) google-beta provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 9 Skipped tests: 2 Affected tests: 3

Click here to see the affected service packages

• vmwareengine

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate|TestAccVmwareengineNetworkPeering_update|TestAccVmwareengineNetworkPolicy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log] TestAccVmwareengineNetworkPeering_update[Error message] [Debug log] TestAccVmwareengineNetworkPolicy_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[swamitagupta]

Hi @SarahFrench The tests seem to be failing since the test project already has ~10 Vmware Engine Networks created at the moment. Could you please clear up all the existing vmwareengine resources of this project? Thanks

[SarahFrench]

Hi @swamitagupta - I'll do my best but as I'm not a Google employee I cannot access the test project directly. I'll see what options are available to me and will ask for the core Terraform team at Google for help after.

[SarahFrench]

I used test project sweepers to remove some google_vmwareengine_network in global and some regions too. Re-running tests: /gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-)) google-beta provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 9 Skipped tests: 2 Affected tests: 3

Click here to see the affected service packages

• vmwareengine

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate|TestAccVmwareengineNetworkPeering_update|TestAccVmwareengineNetworkPolicy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log] TestAccVmwareengineNetworkPeering_update[Error message] [Debug log] TestAccVmwareengineNetworkPolicy_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[SarahFrench]

I found that our sweeper for cleaning up these resources isn't able to delete these resources - once I have my PR to fix that merged it should unblock your progress: https://github.com/GoogleCloudPlatform/magic-modules/pull/10994

[swamitagupta]

Thanks @SarahFrench Please also check if there are any Private Clouds dependant on these VENs which might fail their deletion. There has been a recent change due to which PC Deletions can go long for as long as 24 hrs. This might cause a surge in dangling VENs as well. This change would impact these tests temporarily.

[SarahFrench]

I'm working on it - I am making the existing google_vmwareengine_network sweeper more effective, and I'm adding a sweeper for google_vmwareengine_private_cloud as this wasn't added in the past. Once the latter is in place I will be able to delete these resources in the projects I cannot access directly

[swamitagupta]

Acknowledged, thank you @SarahFrench

[SarahFrench]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-)) google-beta provider: Diff ( 8 files changed, 201 insertions(+), 497 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 9 Skipped tests: 2 Affected tests: 3

Click here to see the affected service packages

• vmwareengine

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate|TestAccVmwareengineNetworkPeering_update|TestAccVmwareengineNetworkPolicy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccVmwareengineNetworkPeering_update[Debug log] TestAccVmwareengineNetworkPolicy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 202 insertions(+), 498 deletions(-)) google-beta provider: Diff ( 8 files changed, 202 insertions(+), 498 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 11 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$ View the build log or the debug log for each test

[swamitagupta]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 202 insertions(+), 498 deletions(-)) google-beta provider: Diff ( 8 files changed, 202 insertions(+), 498 deletions(-))

[modular-magician]

Tests analytics

Total tests: 14 Passed tests: 11 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$ View the build log or the debug log for each test

[SarahFrench]

It looks like that test (TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate ) is failing due to hitting the 4 hour timeout limit - I'll have a go running the test in our non-VCR test environment

Note to self: test here

[SarahFrench]

From running the test above, it failed with an opaque error:

Step 3/8 error: Error running apply: exit status 1
            
            Error: Error waiting for Updating ExternalAddress: Error code 13, message: an internal error has occurred
            
              with google_vmwareengine_external_address.vmw-engine-external-address-primary,
              on terraform_plugin_test.tf line 41, in resource "google_vmwareengine_external_address" "vmw-engine-external-address-primary":
              41: resource "google_vmwareengine_external_address" "vmw-engine-external-address-primary" {