magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Organization mute config

Open thokalavinod opened this issue 1 year ago • 12 comments

Related to http://b/330538229. Issue No: https://b.corp.google.com/issues/339718371

Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support https://cloud.google.com/security-command-center/docs/reference/rest/v2/organizations.locations.muteConfigs

Release Note Template for Downstream PRs (will be copied)

`google_scc_organization_mute_config`

thokalavinod avatar Jun 17 '24 21:06 thokalavinod

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Jun 17 '24 21:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 89 insertions(+)) google-beta provider: Diff ( 1 file changed, 89 insertions(+))

modular-magician avatar Jun 18 '24 16:06 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterV2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Jun 18 '24 16:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 116 insertions(+)) google-beta provider: Diff ( 1 file changed, 116 insertions(+))

modular-magician avatar Jun 18 '24 19:06 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Jun 18 '24 19:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 121 insertions(+)) google-beta provider: Diff ( 1 file changed, 121 insertions(+))

modular-magician avatar Jun 18 '24 20:06 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Jun 18 '24 20:06 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 20 '24 09:06 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 125 insertions(+)) google-beta provider: Diff ( 1 file changed, 125 insertions(+))

modular-magician avatar Jun 20 '24 16:06 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Jun 20 '24 16:06 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 27 '24 09:06 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 01 '24 09:07 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 08 '24 09:07 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 838 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 838 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_mute_config" "primary" {
  description                = # value needed
  filter                     = # value needed
  location                   = # value needed
  organizationmute_config_id = # value needed
  parent                     = # value needed
  type                       = # value needed
}


modular-magician avatar Jul 09 '24 21:07 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccOrganizationMuteConfigExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Jul 09 '24 21:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 837 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 837 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_mute_config (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_mute_config" "primary" {
  organizationmute_config_id = # value needed
}


modular-magician avatar Jul 10 '24 17:07 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccOrganizationMuteConfigExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Jul 10 '24 17:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 831 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 831 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_mute_config (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_mute_config" "primary" {
  organizationmute_config_id = # value needed
}


modular-magician avatar Jul 15 '24 21:07 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterOrganizationMuteConfig_createUpdateDelete
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccOrganizationMuteConfigExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Jul 15 '24 21:07 modular-magician

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 18 '24 09:07 github-actions[bot]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 22 '24 09:07 github-actions[bot]

Obsoleted by https://github.com/GoogleCloudPlatform/magic-modules/pull/11168

rileykarson avatar Jul 24 '24 14:07 rileykarson