GoogleCloudPlatform
[AlloyDB] Support project IDs and project numbers for PSC instances
This PR addresses the issue raised: https://github.com/hashicorp/terraform-provider-google/issues/18327.
With this change, PSC instances can specify the field allowed_consumer_projects as either project IDs or project numbers.
Details about why this change was implemented this way can be found here - https://yaqs.corp.google.com/eng/q/1374949186138537984. Briefly, we want to support the customer specifying either project numbers or IDs, however, the API always returns project numbers.
alloydb: allowed `google_alloydb_instance.psc_instance_config.allowed_consumer_projects` to be specified as either project numbers or project IDs.
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 23 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 23 insertions(+), 8 deletions(-))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 4 files changed, 23 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 23 insertions(+), 8 deletions(-))
Tests analytics
Total tests: 3752
Passed tests: 3366
Skipped tests: 379
Affected tests: 7
Click here to see the affected service packages
all service packages are affected
Action taken
Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbInstance_updatePscInstanceConfig|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample
Get to know how VCR tests work
Tests analytics
Total tests: 3752
Passed tests: 3366
Skipped tests: 379
Affected tests: 7
Click here to see the affected service packages
all service packages are affected
Action taken
Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbInstance_updatePscInstanceConfig|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbInstance_updatePscInstanceConfig[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]
TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
@vmiglani, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 28 days.
This notification can be disabled with the disable-automatic-closure label.
@vmiglani, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 28 days.
This notification can be disabled with the disable-automatic-closure label.
@vmiglani, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 14 days.
This notification can be disabled with the disable-automatic-closure label.
@vmiglani, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 2 weekdays.
This notification can be disabled with the disable-automatic-closure label.
Is it possible to re-open this pull request since lot of customers are complaining about using project numbers rather than IDs?
