magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add support for `google_app_engine_standard_app_version` to TGC

Open delimaneto opened this issue 1 year ago • 12 comments

adding support for appengine.googleapis.com/Version

delimaneto avatar May 29 '24 19:05 delimaneto

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar May 29 '24 19:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 5 files changed, 1080 insertions(+))

modular-magician avatar May 29 '24 20:05 modular-magician

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 31 '24 09:05 github-actions[bot]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 01 '24 09:06 github-actions[bot]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 02 '24 09:06 github-actions[bot]

@rileykarson could you please go ahead with the review?

delimaneto avatar Jun 04 '24 13:06 delimaneto

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

@rileykarson the error that we are facing on the rake-tests seems to be started when the PR(https://github.com/GoogleCloudPlatform/magic-modules/pull/10773) was commited.

Can you take a look on this?

delimaneto avatar Jun 10 '24 14:06 delimaneto

@rileykarson fixed rake-test on https://github.com/GoogleCloudPlatform/magic-modules/pull/10928

delimaneto avatar Jun 10 '24 15:06 delimaneto

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]

Apologies, the change is pretty large and I haven't found time to review it yet.

rileykarson avatar Jun 18 '24 19:06 rileykarson

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

@delimaneto, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

@delimaneto, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jul 23 '24 09:07 github-actions[bot]

@delimaneto, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Aug 02 '24 09:08 github-actions[bot]

@delimaneto, this PR is being closed due to inactivity.

github-actions[bot] avatar Aug 06 '24 09:08 github-actions[bot]