magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add Resource Organization, folder and project Mute Config

Open thokalavinod opened this issue 1 year ago • 103 comments

Related to http://b/330538229. Issue No: https://b.corp.google.com/issues/339717598

Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.muteConfigs https://cloud.google.com/security-command-center/docs/reference/rest/v1/organizations.muteConfigs https://cloud.google.com/security-command-center/docs/reference/rest/v1/projects.muteConfigs

thokalavinod avatar May 23 '24 03:05 thokalavinod

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 23 '24 03:05 google-cla[bot]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar May 23 '24 03:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+)) google-beta provider: Diff ( 3 files changed, 156 insertions(+))

modular-magician avatar May 23 '24 20:05 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • securitycenterV2

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterFolderMuteConfig_basic
  • TestAccSecurityCenterOrganizationMuteConfig_basic
  • TestAccSecurityCenterProjectMuteConfig_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar May 23 '24 20:05 modular-magician

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 28 '24 09:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2343 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 18 files changed, 2343 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar May 29 '24 22:05 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterFolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterOrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_basic
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterprojectMuteConfig_sccV2ProjectMuteConfigBasicExample
  • TestAccSecurityCenterv2FolderMuteConfig_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar May 29 '24 22:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 2344 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 18 files changed, 2344 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar May 30 '24 20:05 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterFolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterOrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_basic
  • TestAccSecurityCenterV2ProjectMuteConfig_basic
  • TestAccSecurityCenterprojectMuteConfig_sccV2ProjectMuteConfigBasicExample
  • TestAccSecurityCenterv2FolderMuteConfig_basic

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar May 30 '24 20:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2356 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2346 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_folder_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_folder_mute_config" "primary" {
  description          = # value needed
  filter               = # value needed
  foldermute_config_id = # value needed
  location             = # value needed
  parent               = # value needed
}

Resource: google_scc_organization_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_organization_mute_config" "primary" {
  description                = # value needed
  filter                     = # value needed
  location                   = # value needed
  organizationmute_config_id = # value needed
  parent                     = # value needed
}

Resource: google_scc_project_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_project_mute_config" "primary" {
  description           = # value needed
  filter                = # value needed
  location              = # value needed
  parent                = # value needed
  projectmute_config_id = # value needed
}

modular-magician avatar May 30 '24 23:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2411 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2401 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_folder_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_folder_mute_config" "primary" {
  description          = # value needed
  filter               = # value needed
  foldermute_config_id = # value needed
  location             = # value needed
  parent               = # value needed
}

Resource: google_scc_organization_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_organization_mute_config" "primary" {
  description                = # value needed
  filter                     = # value needed
  location                   = # value needed
  organizationmute_config_id = # value needed
  parent                     = # value needed
}

Resource: google_scc_project_mute_config (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_project_mute_config" "primary" {
  description           = # value needed
  filter                = # value needed
  location              = # value needed
  parent                = # value needed
  projectmute_config_id = # value needed
}

modular-magician avatar May 31 '24 02:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2411 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2401 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_folder_mute_config (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_folder_mute_config" "primary" {
  foldermute_config_id = # value needed
  location             = # value needed
  parent               = # value needed
}

Resource: google_scc_organization_mute_config (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_organization_mute_config" "primary" {
  location                   = # value needed
  organizationmute_config_id = # value needed
  parent                     = # value needed
}

Resource: google_scc_project_mute_config (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_project_mute_config" "primary" {
  location              = # value needed
  parent                = # value needed
  projectmute_config_id = # value needed
}

modular-magician avatar May 31 '24 18:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2411 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2401 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_mute_config (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_mute_config" "primary" {
  organizationmute_config_id = # value needed
}

Resource: google_scc_v2_project_mute_config (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_mute_config" "primary" {
  projectmute_config_id = # value needed
}

modular-magician avatar May 31 '24 20:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2519 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2509 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 03 '24 09:06 modular-magician

Why is this resource represented by one resource in v1, but three resources in v2?

trodge avatar Jun 03 '24 16:06 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2517 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2507 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 03 '24 17:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2517 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2507 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 03 '24 18:06 modular-magician

Why is this resource represented by one resource in v1, but three resources in v2?

That's the client requirement to convert into 3 seperate files.

thokalavinod avatar Jun 03 '24 18:06 thokalavinod

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2512 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2502 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jun 03 '24 20:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2512 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2502 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

modular-magician avatar Jun 03 '24 21:06 modular-magician

Tests analytics

Total tests: 3746 Passed tests: 3278 Skipped tests: 376 Affected tests: 92

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample
  • TestAccSecurityCenterv2FolderMuteConfig_basic
  • TestAccSecurityCenterv2OrganizationMuteConfig_basic
  • TestAccSecurityCenterv2ProjectMuteConfig_basic

Action taken

Found 92 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccApphubWorkload_apphubWorkloadBasicExample|TestAccApphubWorkload_apphubWorkloadFullExample|TestAccApphubWorkload_apphubWorkloadUpdate|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccDNSManagedZoneIamBindingGenerated|TestAccDNSManagedZoneIamMemberGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccDNSManagedZone_dnsManagedZoneQuickstartExample|TestAccDataSourceApphubDiscoveredWorkload_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDefaultUniverseDomainDisk|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_stoppedSuspendedTargetSize|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample|TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample|TestAccNetworkServicesLbTrafficExtension_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician avatar Jun 03 '24 22:06 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2515 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2505 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

modular-magician avatar Jun 04 '24 00:06 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccApphubWorkload_apphubWorkloadBasicExample[Debug log] TestAccApphubWorkload_apphubWorkloadFullExample[Debug log] TestAccApphubWorkload_apphubWorkloadUpdate[Debug log] TestAccComputeBackendService_withBackend[Debug log] TestAccComputeBackendService_withBackendAndIAP[Debug log] TestAccComputeBackendService_withBackendAndMaxUtilization[Debug log] TestAccComputeBackendService_withMaxConnections[Debug log] TestAccComputeBackendService_withMaxConnectionsPerInstance[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log] TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log] TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log] TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log] TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log] TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log] TestAccComputePerInstanceConfig_statefulIps[Debug log] TestAccComputePerInstanceConfig_update[Debug log] TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log] TestAccComputeRegionBackendService_withBackendInternal[Debug log] TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log] TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log] TestAccComputeRegionPerInstanceConfig_update[Debug log] TestAccDNSManagedZoneIamBindingGenerated[Debug log] TestAccDNSManagedZoneIamMemberGenerated[Debug log] TestAccDNSManagedZoneIamPolicyGenerated[Debug log] TestAccDNSManagedZone_dnsManagedZoneQuickstartExample[Debug log] TestAccDataSourceApphubDiscoveredWorkload_basic[Debug log] TestAccDataSourceGoogleComputeInstanceGroup_fromIGM[Debug log] TestAccDefaultUniverseDomainDisk[Debug log] TestAccIapTunnelInstanceIamBindingGenerated[Debug log] TestAccIapTunnelInstanceIamBindingGenerated_withCondition[Debug log] TestAccIapTunnelInstanceIamMemberGenerated[Debug log] TestAccIapTunnelInstanceIamMemberGenerated_withCondition[Debug log] TestAccIapTunnelInstanceIamPolicyGenerated[Debug log] TestAccIapTunnelInstanceIamPolicyGenerated_withCondition[Debug log] TestAccInstanceGroupManager_resourceManagerTags[Debug log] TestAccInstanceGroupManager_stoppedSuspendedTargetSize[Debug log] TestAccInstanceGroupManager_targetSizeZero[Debug log] TestAccInstanceGroupManager_versions[Debug log] TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log] TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log] TestAccNetworkManagementConnectivityTest_update[Debug log] TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log] TestAccNetworkServicesLbRouteExtension_update[Debug log] TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log] TestAccNetworkServicesLbTrafficExtension_update[Debug log] TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample[Debug log] TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample[Debug log] TestAccRegionInstanceGroupManager_APISideListRecordering[Debug log] TestAccRegionInstanceGroupManager_distributionPolicy[Debug log] TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log] TestAccRegionInstanceGroupManager_stateful[Debug log] TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize[Debug log] TestAccRegionInstanceGroupManager_targetSizeZero[Debug log] TestAccRegionInstanceGroupManager_versions[Debug log] TestAccTags[Debug log] TestAccTagsLocationTagBinding_locationTagBindingzonal[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeAutoscaler_autoscalerBasicExample[Error message] [Debug log] TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log] TestAccComputeAutoscaler_multicondition[Error message] [Debug log] TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log] TestAccComputeAutoscaler_scaleInControl[Error message] [Debug log] TestAccComputeAutoscaler_scaleInControlFixed[Error message] [Debug log] TestAccComputeAutoscaler_scalingSchedule[Error message] [Debug log] TestAccComputeAutoscaler_update[Error message] [Debug log] TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log] TestAccComputeRegionAutoscaler_update[Error message] [Debug log] TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log] TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log] TestAccInstanceGroupManager_basic[Error message] [Debug log] TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log] TestAccInstanceGroupManager_stateful[Error message] [Debug log] TestAccInstanceGroupManager_update[Error message] [Debug log] TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log] TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log] TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log] TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log] TestAccRegionInstanceGroupManager_basic[Error message] [Debug log] TestAccRegionInstanceGroupManager_update[Error message] [Debug log] TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log] TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log] TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jun 04 '24 00:06 modular-magician

Tests analytics

Total tests: 3746 Passed tests: 3278 Skipped tests: 376 Affected tests: 92

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample
  • TestAccSecurityCenterv2FolderMuteConfig_basic
  • TestAccSecurityCenterv2OrganizationMuteConfig_basic
  • TestAccSecurityCenterv2ProjectMuteConfig_basic

Action taken

Found 92 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccApphubWorkload_apphubWorkloadBasicExample|TestAccApphubWorkload_apphubWorkloadFullExample|TestAccApphubWorkload_apphubWorkloadUpdate|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputePerInstanceConfig_removeInstanceOnDestroy|TestAccComputePerInstanceConfig_statefulIps|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccComputeRegionPerInstanceConfig_statefulIps|TestAccComputeRegionPerInstanceConfig_update|TestAccDNSManagedZoneIamBindingGenerated|TestAccDNSManagedZoneIamMemberGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccDNSManagedZone_dnsManagedZoneQuickstartExample|TestAccDataSourceApphubDiscoveredWorkload_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDefaultUniverseDomainDisk|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_resourceManagerTags|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_stoppedSuspendedTargetSize|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_waitForStatus|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample|TestAccNetworkServicesLbRouteExtension_update|TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample|TestAccNetworkServicesLbTrafficExtension_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccRegionInstanceGroupManager_APISideListRecordering|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_resourceManagerTags|TestAccRegionInstanceGroupManager_stateful|TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccTags|TestAccTagsLocationTagBinding_locationTagBindingzonal|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician avatar Jun 04 '24 01:06 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccApphubWorkload_apphubWorkloadBasicExample[Debug log] TestAccApphubWorkload_apphubWorkloadFullExample[Debug log] TestAccApphubWorkload_apphubWorkloadUpdate[Debug log] TestAccComputeBackendService_withBackend[Debug log] TestAccComputeBackendService_withBackendAndIAP[Debug log] TestAccComputeBackendService_withBackendAndMaxUtilization[Debug log] TestAccComputeBackendService_withMaxConnections[Debug log] TestAccComputeBackendService_withMaxConnectionsPerInstance[Debug log] TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log] TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log] TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log] TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log] TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log] TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log] TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log] TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log] TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log] TestAccComputePerInstanceConfig_removeInstanceOnDestroy[Debug log] TestAccComputePerInstanceConfig_statefulIps[Debug log] TestAccComputePerInstanceConfig_update[Debug log] TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log] TestAccComputeRegionBackendService_withBackendInternal[Debug log] TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log] TestAccComputeRegionBackendService_withBackendMultiNic[Debug log] TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log] TestAccComputeRegionPerInstanceConfig_statefulIps[Debug log] TestAccComputeRegionPerInstanceConfig_update[Debug log] TestAccDNSManagedZoneIamBindingGenerated[Debug log] TestAccDNSManagedZoneIamMemberGenerated[Debug log] TestAccDNSManagedZoneIamPolicyGenerated[Debug log] TestAccDNSManagedZone_dnsManagedZoneQuickstartExample[Debug log] TestAccDataSourceApphubDiscoveredWorkload_basic[Debug log] TestAccDataSourceGoogleComputeInstanceGroup_fromIGM[Debug log] TestAccDefaultUniverseDomainDisk[Debug log] TestAccIapTunnelInstanceIamBindingGenerated[Debug log] TestAccIapTunnelInstanceIamBindingGenerated_withCondition[Debug log] TestAccIapTunnelInstanceIamMemberGenerated[Debug log] TestAccIapTunnelInstanceIamMemberGenerated_withCondition[Debug log] TestAccIapTunnelInstanceIamPolicyGenerated[Debug log] TestAccIapTunnelInstanceIamPolicyGenerated_withCondition[Debug log] TestAccInstanceGroupManager_resourceManagerTags[Debug log] TestAccInstanceGroupManager_stoppedSuspendedTargetSize[Debug log] TestAccInstanceGroupManager_targetSizeZero[Debug log] TestAccInstanceGroupManager_versions[Debug log] TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log] TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample[Debug log] TestAccNetworkManagementConnectivityTest_update[Debug log] TestAccNetworkServicesLbRouteExtension_networkServicesLbRouteExtensionBasicExample[Debug log] TestAccNetworkServicesLbRouteExtension_update[Debug log] TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log] TestAccNetworkServicesLbTrafficExtension_update[Debug log] TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample[Debug log] TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample[Debug log] TestAccRegionInstanceGroupManager_APISideListRecordering[Debug log] TestAccRegionInstanceGroupManager_distributionPolicy[Debug log] TestAccRegionInstanceGroupManager_resourceManagerTags[Debug log] TestAccRegionInstanceGroupManager_stateful[Debug log] TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize[Debug log] TestAccRegionInstanceGroupManager_targetSizeZero[Debug log] TestAccRegionInstanceGroupManager_versions[Debug log] TestAccTags[Debug log] TestAccTagsLocationTagBinding_locationTagBindingzonal[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeAutoscaler_autoscalerBasicExample[Error message] [Debug log] TestAccComputeAutoscaler_autoscalerSingleInstanceExample[Error message] [Debug log] TestAccComputeAutoscaler_multicondition[Error message] [Debug log] TestAccComputeAutoscaler_scaleDownControl[Error message] [Debug log] TestAccComputeAutoscaler_scaleInControl[Error message] [Debug log] TestAccComputeAutoscaler_scaleInControlFixed[Error message] [Debug log] TestAccComputeAutoscaler_scalingSchedule[Error message] [Debug log] TestAccComputeAutoscaler_update[Error message] [Debug log] TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleDownControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scaleInControl[Error message] [Debug log] TestAccComputeRegionAutoscaler_scalingSchedule[Error message] [Debug log] TestAccComputeRegionAutoscaler_update[Error message] [Debug log] TestAccDataSourceGoogleComputeInstanceGroupManager[Error message] [Debug log] TestAccInstanceGroupManager_autoHealingPolicies[Error message] [Debug log] TestAccInstanceGroupManager_basic[Error message] [Debug log] TestAccInstanceGroupManager_self_link_unique[Error message] [Debug log] TestAccInstanceGroupManager_stateful[Error message] [Debug log] TestAccInstanceGroupManager_update[Error message] [Debug log] TestAccInstanceGroupManager_waitForStatus[Error message] [Debug log] TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log] TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample[Error message] [Debug log] TestAccRegionInstanceGroupManager_autoHealingPolicies[Error message] [Debug log] TestAccRegionInstanceGroupManager_basic[Error message] [Debug log] TestAccRegionInstanceGroupManager_update[Error message] [Debug log] TestAccTpuV2Vm_tpuV2VmBasicExample[Error message] [Debug log] TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log] TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Jun 04 '24 03:06 modular-magician

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 04 '24 09:06 github-actions[bot]

/gcbrun

trodge avatar Jun 04 '24 17:06 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 21 files changed, 2515 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 19 files changed, 2505 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 3 files changed, 237 insertions(+))

modular-magician avatar Jun 04 '24 18:06 modular-magician

Tests analytics

Total tests: 3747 Passed tests: 3337 Skipped tests: 376 Affected tests: 34

Click here to see the affected service packages
all service packages are affected

Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2FolderMuteConfig_sccV2FolderMuteConfigBasicExample
  • TestAccSecurityCenterV2OrganizationMuteConfig_sccV2OrganizationMuteConfigBasicExample
  • TestAccSecurityCenterV2projectMuteConfig_sccV2ProjectMuteConfigBasicExample
  • TestAccSecurityCenterv2FolderMuteConfig_basic
  • TestAccSecurityCenterv2OrganizationMuteConfig_basic
  • TestAccSecurityCenterv2ProjectMuteConfig_basic

Action taken

Found 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineFlexibleAppVersion_update|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_update|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccComputeInstanceTemplate_sourceImageEncryptionKey|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionInstanceTemplate_sourceImageEncryptionKey|TestAccComputeTargetPool_basic|TestAccDataSourceGoogleComputeInstanceGroupManager|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_self_link_unique|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccLoggingBucketConfigOrganization_basic|TestAccLookerInstance_lookerInstanceEnterpriseFullTestExample|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_update|TestAccTpuV2Vm_tpuV2VmBasicExample|TestAccTpuV2Vm_tpuV2VmFullExample|TestAccVertexAIFeatureOnlineStore_vertexAiFeatureonlinestoreWithBetaFieldsOptimizedExample

Get to know how VCR tests work

modular-magician avatar Jun 04 '24 19:06 modular-magician