magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

temp

Open googlyrahman opened this issue 1 year ago • 8 comments

Release Note Template for Downstream PRs (will be copied)


googlyrahman avatar May 14 '24 20:05 googlyrahman

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar May 14 '24 20:05 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 715 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 715 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_anywhere_cache (0 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_anywhere_cache" "primary" {
  admission_policy = # value needed
  bucket           = # value needed
  ttl              = # value needed
  zone             = # value needed
}

modular-magician avatar May 14 '24 20:05 modular-magician

Tests analytics

Total tests: 93 Passed tests: 87 Skipped tests: 6 Affected tests: 0

Click here to see the affected service packages
  • storage

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar May 14 '24 20:05 modular-magician

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 16 '24 09:05 github-actions[bot]

This is not meant for review.

googlyrahman avatar May 16 '24 16:05 googlyrahman

PR exists for discussing implementation while seeing diffs easily, commenting for accurate review records

NickElliot avatar May 21 '24 22:05 NickElliot

@googlyrahman, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 06 '24 09:06 github-actions[bot]

@googlyrahman, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 20 '24 09:06 github-actions[bot]

@googlyrahman, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jul 02 '24 09:07 github-actions[bot]

@googlyrahman, this PR is being closed due to inactivity.

github-actions[bot] avatar Jul 04 '24 09:07 github-actions[bot]