Dispatch MM unit test workflows based on modular-magician downstream SHAs

[shuyama1]

Following the Cloud Build Guide to pass upstream commit sha between build steps

fixes https://github.com/hashicorp/terraform-provider-google/issues/17924

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[melinath]

@shuyama1 could you look at this today?

[melinath]

If not, just choose a new reviewer.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 1 file changed, 2 insertions(+)) terraform-google-conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

[shuyama1]

@melinath Please take a look when you have time. I'll revert the test changes in .ci/magician/github/set.go, mmv1/third_party/terraform/website/docs/r/apigee_flowhook.html.markdown, mmv1/third_party/tgc/tests/data/bucket.json and mmv1/third_party/tgc/tests/data/bucket.tf before merging the PR. Thanks!

[melinath]

@shuyama1 It looks like the tests didn't run for the latest commit for some reason? Maybe the test branch needs to be updated?

[shuyama1]

@shuyama1 It looks like the tests didn't run for the latest commit for some reason? Maybe the test branch needs to be updated?

The test branch is updated to the latest version: https://github.com/GoogleCloudPlatform/magic-modules/pull/10675/files. I think the tests didn't run due to the files I touched are not an effective go files, so the actions are triggered but actual tests are skipped https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/9686675108/job/26729632752?pr=10671. I double checked the commit sha of tpg, tpgb and tgc in the presubmit-generate-diffs and they did match with the latest version of the commits in magician branches.

I can make a change to some go files that will actually trigger the tests later.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+)) google-beta provider: Diff ( 3 files changed, 29 insertions(+)) terraform-google-conversion: Diff ( 3 files changed, 12 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_endpoint_attachment (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_endpoint_attachment" "primary" {
  test_field = # value needed
}

[modular-magician]

Tests analytics

Total tests: 37 Passed tests: 10 Skipped tests: 27 Affected tests: 0

Click here to see the affected service packages

• apigee

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[shuyama1]

@melinath I kicked off a run to trigger all the tests. tgc-unit-test's failure is probably due to the change I made to the tgc test files (?). I checked the commit sha in the generate-dfifs and they do match with the three latest generated commits in the magician's repos

[github-actions[bot]]

@shuyama1, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@shuyama1, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

[shuyama1]

I'll revert the testing code and merge the PR later today

[github-actions[bot]]

This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+)) google-beta provider: Diff ( 3 files changed, 29 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_endpoint_attachment (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_endpoint_attachment" "primary" {
  test_field = # value needed
}