Terraform Restore Improvements for GKEBackup

[avijitagarwal195]

Adding changes to support restore improvements to Backup For GKE. Fixes b/327225667

Release Note Template for Downstream PRs (will be copied)

 -  gkebackup: added `backup_schedule.0.backup_config.0.permissive_mode` field to `google_gke_backup_backup_plan` resource
 -  gkebackup: added `restore_config.0.restore_order` field to `google_gke_backup_restore_plan` resource
 -  gkebackup: added `restore_config.0.volume_data_restore_policy_bindings` field to `google_gke_backup_restore_plan` resource
 -  gkebackup: added new enum values `MERGE_SKIP_ON_CONFLICT`, `MERGE_REPLACE_VOLUME_ON_CONFLICT` and `MERGE_REPLACE_ON_CONFLICT` to field `restore_config.0.namespaced_resource_restore_mode` in `google_gke_backup_restore_plan` resource

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_backup_restore_plan (14 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_backup_restore_plan" "primary" {
  restore_config {
    restore_order {
      group_kind_dependencies {
        requiring {
          resource_group = # value needed
          resource_kind  = # value needed
        }
        satisfying {
          resource_group = # value needed
          resource_kind  = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 19 Skipped tests: 0 Affected tests: 4

Click here to see the affected service packages

• gkebackup

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 19 Skipped tests: 0 Affected tests: 4

Click here to see the affected service packages

• gkebackup

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[avijitagarwal195]

The newly added tests are failing in this PR because the new fields are hidden behind API visibility label. I will wait till the visibility labels are removed and pushed to production and then re-trigger the tests in CI. The ETA for visibility labels to be removed in mid of May.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 19 Skipped tests: 0 Affected tests: 4

Click here to see the affected service packages

• gkebackup

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsRestoreModeExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderingExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeRestorePolicyBindingsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 19 Skipped tests: 0 Affected tests: 4

Click here to see the affected service packages

• gkebackup

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeResExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderExample[Error message] [Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeResExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[zli82016]

Feel free to let me know when the PR is ready for review.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 19 Skipped tests: 0 Affected tests: 4

Click here to see the affected service packages

• gkebackup

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderExample|TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeResExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_gkebackupBackupplanPermissiveExample[Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanRestoreOrderExample[Debug log] TestAccGKEBackupRestorePlan_gkebackupRestoreplanVolumeResExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[avijitagarwal195]

/gcbrun

[avijitagarwal195]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 6 files changed, 1037 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 23 Passed tests: 22 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages

• gkebackup

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccGKEBackupRestorePlan_gkebackupRestoreplanGitopsModeExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[avijitagarwal195]

@zli82016 This PR is ready for review now. The visibility labels have been removed and the added acceptance tests are running successfully now. Thank you.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1287 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 8 files changed, 1287 insertions(+), 3 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 178 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24 Passed tests: 22 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages

• gkebackup

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccGKEBackupBackupPlan_update|TestAccGKEBackupRestorePlan_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccGKEBackupBackupPlan_update[Debug log] TestAccGKEBackupRestorePlan_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test