magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

bigquery_table - add support for `external_data_configuration.bigtable_options``

Open DrFaust92 opened this issue 2 months ago • 1 comments

Release Note Template for Downstream PRs (will be copied)

bigquery: added `external_data_configuration.bigtable_options` to `google_bigquery_table`

DrFaust92 avatar Apr 30 '24 06:04 DrFaust92

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 30 '24 06:04 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-)) google-beta provider: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_table (138 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_table" "primary" {
  external_data_configuration {
    bigtable_options {
      column_family {
        column {
          qualifier_encoded = # value needed
          qualifier_string  = # value needed
        }
      }
    }
    google_sheets_options {
      range = # value needed
    }
  }
}

modular-magician avatar May 01 '24 20:05 modular-magician

Tests analytics

Total tests: 116 Passed tests: 104 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages
  • bigquery

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar May 01 '24 20:05 modular-magician

NickElliot I have tested it locally and tests have passed but i dont have the output handy at this point 🙏

DrFaust92 avatar May 10 '24 10:05 DrFaust92