magic-modules
magic-modules copied to clipboard
bigquery_table - add support for `external_data_configuration.bigtable_options``
Release Note Template for Downstream PRs (will be copied)
bigquery: added `external_data_configuration.bigtable_options` to `google_bigquery_table`
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-))
google-beta
provider: Diff ( 3 files changed, 392 insertions(+), 4 deletions(-))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_bigquery_table
(138 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_bigquery_table" "primary" {
external_data_configuration {
bigtable_options {
column_family {
column {
qualifier_encoded = # value needed
qualifier_string = # value needed
}
}
}
google_sheets_options {
range = # value needed
}
}
}
Tests analytics
Total tests: 116
Passed tests: 104
Skipped tests: 12
Affected tests: 0
Click here to see the affected service packages
- bigquery
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
NickElliot I have tested it locally and tests have passed but i dont have the output handy at this point 🙏
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders
to disable these notifications.