magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

[AlloyDB] Private Service Connect (PSC) Support

Open vmiglani opened this issue 2 months ago • 4 comments

Description: Changes for supporting Private Service Connect (PSC) in Terraform.

Issue - https://b.corp.google.com/issues/313702463

alloydb: added `psc_config` field to `google_alloydb_cluster` resource
alloydb: added `psc_instance_config` field to `google_alloydb_instance` resource
alloydb: added`psc_config.0.psc_enabled` to the `exactly_one_of` field network restrictions to `google_alloydb_cluster` resource

vmiglani avatar Apr 30 '24 00:04 vmiglani

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 30 '24 00:04 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 348 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 348 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 80 insertions(+))

modular-magician avatar Apr 30 '24 00:04 modular-magician

Tests analytics

Total tests: 67 Passed tests: 61 Skipped tests: 4 Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_withPrivateServiceConnect|TestAccAlloydbInstance_updatePscInstanceConfig

Get to know how VCR tests work

modular-magician avatar Apr 30 '24 00:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbCluster_withPrivateServiceConnect[Error message] [Debug log] TestAccAlloydbInstance_updatePscInstanceConfig[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 30 '24 00:04 modular-magician