magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

add Update command to go resource template

Open NickElliot opened this issue 2 months ago • 2 comments

Unfortunately some major TODOs:

Two functions in terraform.rb need to be converted to a go equivalent. Then logic in the template on one of these functions requires creating a map grouping fields by shared attributes.

  • field_specific_update_methods
  • properties_by_custom_update
  • group_by / key[:]

due to update mask being a nested template, it is not rendering at the moment but should be a smaller addition than the others. there also appears to be an issue where $.UpdateMask is not flagging itself true when it should be based on comparing an output file with one currently in TPG (as dummy text within its block did not render).

Release Note Template for Downstream PRs (will be copied)


NickElliot avatar Apr 29 '24 16:04 NickElliot

cc @zli82016

NickElliot avatar Apr 29 '24 16:04 NickElliot

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Apr 29 '24 16:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar May 01 '24 21:05 modular-magician