Secure Web Proxy fields gatewaySecurityPolicy and certificateUrls supports updates.

[Samir-Cit]

This PR change the fields gatewaySecurityPolicy and certificateUrls on Secure Web Proxy (google_network_services_gateway) resource so both can be updatable.

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/14600

• It was needed a new pre-update code to be able to update those fields.
• Also changed the beta version of the product to use v1beta1.
• Tests were updated to match the new version.
• Other small indentation (nit) fixes on this PR.

Release Note Template for Downstream PRs (will be copied)

gateway: fixed `gatewaySecurityPolicy` and  `certificateUrls` field in `google_network_services_gateway` to be changeble.

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 237 insertions(+), 219 deletions(-)) google-beta provider: Diff ( 13 files changed, 258 insertions(+), 240 deletions(-)) terraform-google-conversion: Diff ( 11 files changed, 22 insertions(+), 22 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3638 Passed tests: 3222 Skipped tests: 369 Affected tests: 47

Click here to see the affected service packages

all service packages are affected

Action taken

Found 47 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetBasicExample|TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetDualTokenExample|TestAccNetworkServicesEdgeCacheKeyset_update|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginV4authExample|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceBasicExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample|TestAccNetworkServicesEdgeCacheService_updateAndImport|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample|TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesGateway_minimalSwp|TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork|TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork|TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample|TestAccNetworkServicesGateway_networkServicesGatewayBasicExample|TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample|TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample|TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses|TestAccNetworkServicesGateway_update|TestAccNetworkServicesGateway_updateSwp|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteActionsExample|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteBasicExample|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteMatchesAndActionsExample|TestAccNetworkServicesGrpcRoute_update|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteActionsExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteBasicExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMatchesAndActionsExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMeshBasicExample|TestAccNetworkServicesHttpRoute_update|TestAccNetworkServicesMesh_networkServicesMeshBasicExample|TestAccNetworkServicesMesh_networkServicesMeshNoPortExample|TestAccNetworkServicesMesh_update|TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample|TestAccNetworkServicesServiceBinding_update|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample|TestAccNetworkServicesTcpRoute_update|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample|TestAccNetworkServicesTlsRoute_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample[Debug log] TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample[Debug log] TestAccNetworkServicesEndpointPolicy_update[Debug log] TestAccNetworkServicesGateway_minimalSwp[Debug log] TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork[Debug log] TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayBasicExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses[Debug log] TestAccNetworkServicesGateway_update[Debug log] TestAccNetworkServicesGateway_updateSwp[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteActionsExample[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteBasicExample[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteMatchesAndActionsExample[Debug log] TestAccNetworkServicesGrpcRoute_update[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteActionsExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteBasicExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMatchesAndActionsExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMeshBasicExample[Debug log] TestAccNetworkServicesHttpRoute_update[Debug log] TestAccNetworkServicesMesh_networkServicesMeshBasicExample[Debug log] TestAccNetworkServicesMesh_networkServicesMeshNoPortExample[Debug log] TestAccNetworkServicesMesh_update[Debug log] TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample[Debug log] TestAccNetworkServicesServiceBinding_update[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample[Debug log] TestAccNetworkServicesTcpRoute_update[Debug log] TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample[Debug log] TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample[Debug log] TestAccNetworkServicesTlsRoute_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetBasicExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetDualTokenExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheKeyset_update[Error message] [Debug log] TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginV4authExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheOrigin_updateAndImport[Error message] [Debug log] TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceBasicExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample[Error message] [Debug log] TestAccNetworkServicesEdgeCacheService_updateAndImport[Error message] [Debug log] TestAccNetworkServicesTlsRoute_networkServicesTlsRouteGatewayBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 237 insertions(+), 219 deletions(-)) google-beta provider: Diff ( 2 files changed, 237 insertions(+), 219 deletions(-))

[modular-magician]

Tests analytics

Total tests: 47 Passed tests: 12 Skipped tests: 0 Affected tests: 35

Click here to see the affected service packages

• networkservices

Action taken

Found 35 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample|TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample|TestAccNetworkServicesEndpointPolicy_update|TestAccNetworkServicesGateway_minimalSwp|TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork|TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork|TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample|TestAccNetworkServicesGateway_networkServicesGatewayBasicExample|TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample|TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample|TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses|TestAccNetworkServicesGateway_update|TestAccNetworkServicesGateway_updateSwp|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteActionsExample|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteBasicExample|TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteMatchesAndActionsExample|TestAccNetworkServicesGrpcRoute_update|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteActionsExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteBasicExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMatchesAndActionsExample|TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMeshBasicExample|TestAccNetworkServicesHttpRoute_update|TestAccNetworkServicesMesh_networkServicesMeshBasicExample|TestAccNetworkServicesMesh_networkServicesMeshNoPortExample|TestAccNetworkServicesMesh_update|TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample|TestAccNetworkServicesServiceBinding_update|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample|TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample|TestAccNetworkServicesTcpRoute_update|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample|TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample|TestAccNetworkServicesTlsRoute_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyBasicExample[Debug log] TestAccNetworkServicesEndpointPolicy_networkServicesEndpointPolicyEmptyMatchExample[Debug log] TestAccNetworkServicesEndpointPolicy_update[Debug log] TestAccNetworkServicesGateway_minimalSwp[Debug log] TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentNetwork[Debug log] TestAccNetworkServicesGateway_multipleSwpGatewaysDifferentSubnetwork[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayAdvancedExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayBasicExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewayMultipleSwpSameNetworkExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyExample[Debug log] TestAccNetworkServicesGateway_networkServicesGatewaySecureWebProxyWithoutAddresses[Debug log] TestAccNetworkServicesGateway_update[Debug log] TestAccNetworkServicesGateway_updateSwp[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteActionsExample[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteBasicExample[Debug log] TestAccNetworkServicesGrpcRoute_networkServicesGrpcRouteMatchesAndActionsExample[Debug log] TestAccNetworkServicesGrpcRoute_update[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteActionsExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteBasicExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMatchesAndActionsExample[Debug log] TestAccNetworkServicesHttpRoute_networkServicesHttpRouteMeshBasicExample[Debug log] TestAccNetworkServicesHttpRoute_update[Debug log] TestAccNetworkServicesMesh_networkServicesMeshBasicExample[Debug log] TestAccNetworkServicesMesh_networkServicesMeshNoPortExample[Debug log] TestAccNetworkServicesMesh_update[Debug log] TestAccNetworkServicesServiceBinding_networkServicesServiceBindingBasicExample[Debug log] TestAccNetworkServicesServiceBinding_update[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteActionsExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteBasicExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteGatewayBasicExample[Debug log] TestAccNetworkServicesTcpRoute_networkServicesTcpRouteMeshBasicExample[Debug log] TestAccNetworkServicesTcpRoute_update[Debug log] TestAccNetworkServicesTlsRoute_networkServicesTlsRouteBasicExample[Debug log] TestAccNetworkServicesTlsRoute_networkServicesTlsRouteMeshBasicExample[Debug log] TestAccNetworkServicesTlsRoute_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test